1247175 - libavcodec.so.57 not supported when micro version is > 100

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gerald Squelart (he/him)]

FFmpeg's libavcodec's micro version has recently been bumped from 100 to 101.
Due to a misunderstanding, we assumed that the micro version (of version 57) would always remain exactly 100:
http://mxr.mozilla.org/mozilla-central/source/dom/media/platforms/ffmpeg/FFmpegLibWrapper.cpp#43

The test should be relaxed to allow micro versions greater or equal to 100.

This code dates from bug 1232268, which landed in FF46, so we should uplift a fix to Aurora-46 if possible.

Comment 1

[Gerald Squelart (he/him)]

Attachment: MozReview Request: Bug 1247175 - Accept libavcodec 57.100+ - r?jya

Review commit: https://reviewboard.mozilla.org/r/34323/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34323/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8717788 [details]
MozReview Request: Bug 1247175 - Accept libavcodec 57.100+ - r?jya

https://reviewboard.mozilla.org/r/34323/#review31011

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1568bce05431

Comment 4

[Gerald Squelart (he/him)]

NI:myself to request uplift to Aurora-46.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1568bce05431

Comment 6

[Gerald Squelart (he/him)]

Attachment: 1247175-accept-libavcodec-57-101-plus.patch

Approval Request Comment
[Feature/regressing bug #]: MP4 playback on Linux using FFmpeg
[User impact if declined]: MP4 playback would stop working if users upgrade their install of FFmpeg (directly, or indirectly through OS upgrades).
[Describe test coverage new/current, TreeHerder]: Lots of media tests, 2 days in Nightly, try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=79f3af745bed
[Risks and why]: Tiny change ('!=100' -> '<100') to allow future minor versions of FFmpeg 57, so I don't see any risks.
[String/UUID change made/needed]: None.

Comment 7

[Gerald Squelart (he/him)]

As per comment #0, the issue is with code that landed in FF46 (currently Aurora), see bug 1232268.

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Recent regression in 46, tracking.

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8719218 [details] [diff] [review]
1247175-accept-libavcodec-57-101-plus.patch

Fix for recent regression, try push ok. Please uplift to aurora.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f20140e67cd

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8719218 [details] [diff] [review]
1247175-accept-libavcodec-57-101-plus.patch

Should patch 1232268 be approved, we always need this one (though it will need rebasing, still two characters change)

Approval Request Comment
[Feature/regressing bug #]: 1247175
[User impact if declined]: New LTS version of various distributions will ship with FFmpeg 3.0. ESR45 will not be usable on those systems.
[Describe test coverage new/current, TreeHerder]: in central for a few weeks.
[Risks and why]: Low, it's well tested and there isn't much to it.
[String/UUID change made/needed]: None

This means ESR45 won't be able to play mp4, mp3, aac etc...

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8719218 [details] [diff] [review]
1247175-accept-libavcodec-57-101-plus.patch

Want that in 45 too, taking & should be in 45 beta 10

Comment 13

[Jean-Yves Avenard [:jya]]

this bugs only make sense if bug 1232268 is approved for beta.

Comment 14

[Carsten Book [:Tomcat]]

(In reply to Jean-Yves Avenard [:jya] from comment #13)
> this bugs only make sense if bug 1232268 is approved for beta.

holding since bug 1232268  has conflicts

Comment 15

[Gerald Squelart (he/him)]

Thank you Carsten and Jean-Yves.
https://hg.mozilla.org/releases/mozilla-beta/rev/54424f42b757