git mozreview tests fail locally

NEW
Unassigned

Status

3 years ago
3 years ago

People

(Reporter: glandium, Unassigned)

Tracking

Details

(Reporter)

Description

3 years ago
(probably the wrong component)

Essentially all the tests are failing with output difference such as:

-  adding hg::http://$DOCKER_HOSTNAME:$HGPORT/test-repo as remote "review"
+  adding hg::http://172.17.42.1:$HGPORT/test-repo as remote "review"

test-mozreview-push-basic.t however does have a real failure too:
+  error: reviewboard error: You don't have permission for this (HTTP 403, API Error 101)
+  [1]
(Reporter)

Comment 1

3 years ago
For clarification, this happens after I cleaned up every docker image and recreated them from a mercurial clone.

I'm also sometimes getting 401s instead of 403s on test-mozreview-push-basic.t

Comment 2

3 years ago
Bug 1245931 (just landed) should fix DOCKER_HOSTNAME on linux. Please let me know if it doesn't work for you.
(Reporter)

Comment 3

3 years ago
And because I'm masochistic, I tried again on a fresh EC2 instance (Amazon Linux AMI 2015.09.1 AMI), running the following:

sudo yum update -y
sudo yum install -y docker git mercurial gcc xz-devel libffi-devel openssl-devel libxml2-devel libxslt-devel openldap-devel
sudo service docker start
sudo usermod -a -G docker ec2-user
(logout-relogin)
hg clone https://hg.mozilla.org/hgcustom/version-control-tools
cd version-control-tools
./create-test-environment
. ./venv/bin/activate
./run-tests git/tests

That still failed.
(Reporter)

Comment 4

3 years ago
(In reply to Dan Minor [:dminor] from comment #2)
> Bug 1245931 (just landed) should fix DOCKER_HOSTNAME on linux. Please let me
> know if it doesn't work for you.

WARNING: Not running tests optimally. Specify -j to run tests in parallel.
/home/ec2-user/version-control-tools/testing/vcttesting/docker.py:174: UserWarning: Warning: Unable to determine ip address of the docker gateway. Please ensure docker is listening on a tcp socket by setting -H tcp://127.0.0.1:4243 in your docker configuration file.
  warnings.warn('Warning: Unable to determine ip '
ss.s
Skipped test-mozreview-commit-selection.t: skipped
Skipped test-mozreview-push-basic.t: skipped
Skipped test-mozreview-configure.t: skipped
# Ran 1 tests, 3 skipped, 0 warned, 0 failed.


After doing what it says (which, if you ask me, I shouldn't have to do), it fails to connect to the docker server, so it skips all tests:

WARNING: Not running tests optimally. Specify -j to run tests in parallel.
ss.s
Skipped test-mozreview-commit-selection.t: skipped
Skipped test-mozreview-push-basic.t: skipped
Skipped test-mozreview-configure.t: skipped
# Ran 1 tests, 3 skipped, 0 warned, 0 failed.


Note it doesn't say it can't connect, only running create-test-environment again does:

Building Docker images.
This could take a while and may consume a lot of internet bandwidth.
If you don't want Docker images, it is safe to hit CTRL+c to abort this.
Docker is not available!
You will not be able to run tests that require Docker.
Please see https://docs.docker.com/installation/ for how to install Docker.
When Docker is installed, re-run this script
finished creating test environment
(Reporter)

Comment 5

3 years ago
Good joke, after restarting the docker server *without* -H tcp://127.0.0.1:4243, it all works (for a value of works where running these 4 tests takes 5 minutes).
(Reporter)

Comment 6

3 years ago
So, I tried again in a fresh VM. If after create-test-environment barfed about the tcp socket, I restart docker, *without* changing its configuration, re-running create-test-environment works.
(Assignee)

Updated

3 years ago
Product: Developer Services → MozReview

Updated

3 years ago
Component: General → Testing / Development Environment
You need to log in before you can comment on or make changes to this bug.