[CID 749520] Free a pointer

RESOLVED FIXED in Firefox 48

Status

()

Product:
Toolkit
Component:
Application Update
Type:
defect
Status:
RESOLVED FIXED
Opened:
3 years ago
Updated:
3 years ago

People

(Reporter: paul.bignier, Assigned: paul.bignier)

Tracking

Version:
47 Branch
Target:
mozilla48
Points:
---
Duplicates:
1247922

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

0001-CID-749520-Free-a-pointer.patch
1.40 KB, patch
rstrong
: review+
Details | Diff | Splinter Review
Assignee

Description

•
3 years ago 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20160127060627
 Assignee

Updated

•
3 years ago
Attachment #8717842 - Flags: review?(netzen)
Assignee: nobody → paul.bignier
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8717842 - Flags: review?(netzen) → review?(robert.strong.bugs)

Comment 2

•
3 years ago 
Comment on attachment 8717842 [details] [diff] [review]
0001-CID-749520-Free-a-pointer.patch

Please also add free(mbuf) for the other early return slightly below in the same function

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/updater/updater.cpp#3858

I'll r+ it with that and if you want I can land it for you as well.
Attachment #8717842 - Flags: review?(robert.strong.bugs) → review-
 Assignee

Comment 3

•
3 years ago 
> I'll r+ it with that and if you want I can land it for you as well.

Yes please :)
Attachment #8717842 - Attachment is obsolete: true
Attachment #8739868 - Flags: review?(robert.strong.bugs)
Attachment #8739868 - Flags: review?(robert.strong.bugs) → review+

Comment 6

•
3 years ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/ea7e3da670d6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.