1247219 - Front-end work for groups edit refactor

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Pierros Papadeas [:pierros]]

According to specs of 1243774

This should result to a PR of static front-end code

Comment 1

[Pierros Papadeas [:pierros]]

After the PR of static code is in, this should be taken by :tasos or :nemo to connect it to the back-end

Comment 2

[Nikos Roussos [:comzeradd]]

Relevant commit: https://github.com/comzeradd/mozillians/commit/4994d2f91298d9aef5750999bd3b25cafe49dd2f

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/d3e980839bc431eac05d09bd1614f3ae9d1a9009
[bug 1247219] Group settings UI

Comment 4

[John Giannelos [:nemo-yiannis]]

Some comments regarding the current UI on dev:

* Fix UI in group create form
 * Spacing between `name` and `type` needs some fine-tuning
* Group pending invitations
 * When no invitations exist, UI needs some fine-tuning to look better
* Terms and expiration
 * Maybe we can consolidate those in the same panel
 * UI needs some love (mostly regarding spacing)
 * We need to add an informative text to let users know that this is a markdown field + a link to some markdown documentation

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/fa9a82a16a24a91e62f2fff31f2cd9e8bf583f0c
[Fix bug 1247219] UI fixes for new group settings

* Minimize space on create group modal
* Use even space on no pending invitations text
* Minimize space on group types descriptions
* Add markdown informative text on terms
* Fix group access criteria toggle

https://github.com/mozilla/mozillians/commit/89856189c7944bfb28de745dca4b16b3be65edc9
Merge pull request #1389 from comzeradd/group-settings-ui

[Fix bug 1247219] UI fixes for new group settings

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/bca1df468c27a69ef2c35404a2cd817238d0b176
[bug 1247219] Add a link to show_group in group_edit page.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/82775fdb04873b8336ba6c3e0a7c186dd2f8a1ea
[bug 1247219] Capitalize first letters in group edit submit buttons.

https://github.com/mozilla/mozillians/commit/f8e46e2a5c134658ee26811d2f4c6a55ae51ab51
Merge pull request #1410 from akatsoulas/edit-groups-fix-typo

[bug 1247219] Capitalize first letters in group edit submit buttons.

Comment 8

[John Giannelos [:nemo-yiannis]]

Overflowing text is not working as expected:
https://i.imgur.com/XyQQnGW.png

Comment 9

[John Giannelos [:nemo-yiannis]]

* Curators autocomplete field overflows panel in mobile
* Curators autocomplete field is misaligned in mobile

https://imgur.com/bXfLV4s

Comment 10

[John Giannelos [:nemo-yiannis]]

Terms checkboxes are misaligned in mobile

https://i.imgur.com/VzYke4b.png

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/7950c0a731ab1b85f694be64f2fcb433c7c2b0b2
[bug 1247219] Minor ui fixes.

https://github.com/mozilla/mozillians/commit/7850f4e7741b49c9d9ab9b99484100b744a127bb
Merge pull request #1416 from akatsoulas/minor-ui-fixes

[bug 1247219] Minor ui fixes.

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/23b8b7d8242c9070d432d9e89b75f3fde0d1c64a
[Bug 1247219] Fix Group settings UI elements

* Fix Group title overflow text
* Limit select boxes width on mobile
* Proper arrangement of checkbox labels

https://github.com/mozilla/mozillians/commit/cc0b42711d85d59e9440091ff4fd49b06015e25c
Merge pull request #1418 from comzeradd/1247219

[Bug 1247219] Fix Group settings UI elements