Closed Bug 1247343 Opened 5 years ago Closed 5 years ago

Support T pushes for try

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: armenzg, Assigned: dustin)

References

Details

From philor:
"try: -b do -p all -u all[Ubuntu]" and " try: -b do -p all -u all[x64]"
are "T pushes", which are supposed to build on every platform but only
run tests on either both Linux32 and Linux64 in the first case or only
Linux64 in the second case. Neither one runs TC Linux64 debug tests.

tier-1 requirement.
Blocks: 1234759
Component: General → Integration
No longer blocks: 1234759
Blocks: 1243759
Blocks: 1247703
Component: Integration → Task Configuration
No longer blocks: 1247703
Depends on: 1247703
Blocks: 1080265
No longer blocks: 1243024
Duplicate of this bug: 1266096
Duplicate of this bug: 1270343
Didn't this work in the past?
It still does work, on platforms where the tests are still run by buildbot rather than by taskcluster. Just unfortunate that 99% of T pushes use Linux64 as the platform to run tests on, and we switched to doing those tests on taskcluster without fixing this blocker for switching.
I believe the new task-graph generation system will handle these correctly.  At least, it will if I can figure out how "Ubuntu" is translated to "linux32 and linux64" and "x64" is translated to "linux64".
Assignee: nobody → dustin
Sorry about that! I should have been more careful moving dependencies.
Thanks dustin for taking care of this.
The test platforms in [brackets] are substring-matched against test platform prettyNames.

From :sfink:

11:44:30 <sfink> builders have a single prettyName, testers have a whole list of them, I forget which one gets matched against for the -t foo[...] filter
11:45:43 <sfink> IMHO, if you can come up with something that the trychooser web UI can generate, and it works in a vaguely sane manner, then we'd be far ahead of where we are now
11:45:53 <sfink> the syntax does not need to match exactly
11:46:27 <sfink> the current -t all[x64] T push, for example, depends on the substring "x64" just happening to appear in all the prettyName for 64-bit linux but not other 64-bit platforms, which is crazy
11:46:54 <sfink> er, I mean -u foo[...]

I'll try to come up with something reasonably compatible during the transition, without guaranteeing an exact match.  I expect that, after we get the entire task-graph in-tree, we'll want to make a more substantial redesign (and I've talked with ahal about that).
For reference, of about 700 pushes to try, these were the test platform strings used:

10.10
10.10,Android 4.3 API15+
10.10,Windows XP,Windows 7,Windows 8
10.6
10.6,10.10
10.6,Windows XP
Android 2.3 API9,Android 4.3 API15+
Android 4.3 API15+
Ubuntu
Ubuntu,-x64
Ubuntu,10.10,Windows 7,-x64
Ubuntu,10.10,Windows XP,Windows 7,Windows 8
Ubuntu,10.6,10.10,Windows XP,Windows 7,Windows 8
Ubuntu,10.6,10.10,Windows XP,Windows 7,Windows 8,Android 2.3 API9,Android 4.3 API15+
Ubuntu,10.6,10.10,Windows XP,Windows 7,Windows 8,Android 4.3 API15+
Ubuntu,10.8,10.10,10.10.5,Windows XP,Windows 7,Windows 8
Windows 7
Windows 7 VM
Windows 7,Windows 8
Windows XP
Windows XP,Windows 7
Windows XP,Windows 7,Windows 8
Windows XP,Windows 8
b2g
win32,win64
x64
x64,10.10
x64,10.10,Windows XP,Windows 7,Windows 8
x64,10.6,10.10
x64,Ubuntu,10.6,10.10
x64,Windows 7
x64,Windows XP,Windows 7,Windows 8
See bug 1258497 comment 22 for the new implementation of this.
This landed in bug 1258497
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
hey :philor, are you able to do T pushes on taskcluster/try?
Flags: needinfo?(philringnalda)
Yes.
Flags: needinfo?(philringnalda)
Status: RESOLVED → VERIFIED
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.