1247343 - Support T pushes for try

Status: VERIFIED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Armen [:armenzg]]

From philor:
"try: -b do -p all -u all[Ubuntu]" and " try: -b do -p all -u all[x64]"
are "T pushes", which are supposed to build on every platform but only
run tests on either both Linux32 and Linux64 in the first case or only
Linux64 in the second case. Neither one runs TC Linux64 debug tests.

tier-1 requirement.

Comment 3

[Botond Ballo [:botond]]

Didn't this work in the past?

Comment 4

[Phil Ringnalda (:philor)]

It still does work, on platforms where the tests are still run by buildbot rather than by taskcluster. Just unfortunate that 99% of T pushes use Linux64 as the platform to run tests on, and we switched to doing those tests on taskcluster without fixing this blocker for switching.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

I believe the new task-graph generation system will handle these correctly.  At least, it will if I can figure out how "Ubuntu" is translated to "linux32 and linux64" and "x64" is translated to "linux64".

Comment 6

[Armen [:armenzg]]

Sorry about that! I should have been more careful moving dependencies.
Thanks dustin for taking care of this.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

The test platforms in [brackets] are substring-matched against test platform prettyNames.

From :sfink:

11:44:30 <sfink> builders have a single prettyName, testers have a whole list of them, I forget which one gets matched against for the -t foo[...] filter
11:45:43 <sfink> IMHO, if you can come up with something that the trychooser web UI can generate, and it works in a vaguely sane manner, then we'd be far ahead of where we are now
11:45:53 <sfink> the syntax does not need to match exactly
11:46:27 <sfink> the current -t all[x64] T push, for example, depends on the substring "x64" just happening to appear in all the prettyName for 64-bit linux but not other 64-bit platforms, which is crazy
11:46:54 <sfink> er, I mean -u foo[...]

I'll try to come up with something reasonably compatible during the transition, without guaranteeing an exact match.  I expect that, after we get the entire task-graph in-tree, we'll want to make a more substantial redesign (and I've talked with ahal about that).

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

For reference, of about 700 pushes to try, these were the test platform strings used:

10.10
10.10,Android 4.3 API15+
10.10,Windows XP,Windows 7,Windows 8
10.6
10.6,10.10
10.6,Windows XP
Android 2.3 API9,Android 4.3 API15+
Android 4.3 API15+
Ubuntu
Ubuntu,-x64
Ubuntu,10.10,Windows 7,-x64
Ubuntu,10.10,Windows XP,Windows 7,Windows 8
Ubuntu,10.6,10.10,Windows XP,Windows 7,Windows 8
Ubuntu,10.6,10.10,Windows XP,Windows 7,Windows 8,Android 2.3 API9,Android 4.3 API15+
Ubuntu,10.6,10.10,Windows XP,Windows 7,Windows 8,Android 4.3 API15+
Ubuntu,10.8,10.10,10.10.5,Windows XP,Windows 7,Windows 8
Windows 7
Windows 7 VM
Windows 7,Windows 8
Windows XP
Windows XP,Windows 7
Windows XP,Windows 7,Windows 8
Windows XP,Windows 8
b2g
win32,win64
x64
x64,10.10
x64,10.10,Windows XP,Windows 7,Windows 8
x64,10.6,10.10
x64,Ubuntu,10.6,10.10
x64,Windows 7
x64,Windows XP,Windows 7,Windows 8

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

See bug 1258497 comment 22 for the new implementation of this.

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

This landed in bug 1258497

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

hey :philor, are you able to do T pushes on taskcluster/try?

Comment 12

[Phil Ringnalda (:philor)]

Yes.