1247362 - move mAnonymousGlobalScope tracing into nsMessageManagerScriptExecutor

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nathan Froyd [:froydnj]]

It's silly that we trace nsMessageManagerScriptExecutor::mAnonymousGlobalScope
in its separate subclasses.  mccr8 points out this is probably because we don't
have a good way of inheriting from multiple CC'd classes at the moment.  Be
that as it may, we can at least make things better by moving the common code
into a method on nsMessageManagerScriptExecutor and calling that from the
subclasses.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: move mAnonymousGlobalScope tracing into nsMessageManagerScriptExecutor

Having a Trace method seems to be how things are done elsewhere, though that's
not very a descriptive name.  I could change things to call:

  tmp->nsMessageManagerScriptExecutor::Trace(aCallbacks, aClosure);

to make things a little more obvious at the callsites, if you like.

Comment 2

[Andrew McCreight [:mccr8]]

(In reply to Nathan Froyd [:froydnj] from comment #1)
> Having a Trace method seems to be how things are done elsewhere, though
> that's
> not very a descriptive name.  I could change things to call:
> 
>   tmp->nsMessageManagerScriptExecutor::Trace(aCallbacks, aClosure);
> 
> to make things a little more obvious at the callsites, if you like.
Yes, I think that would be nicer, thanks.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66066bb4a97e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66066bb4a97e