Closed Bug 1247374 Opened 9 years ago Closed 9 years ago

Make an enum for scroll origins instead of using atoms

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox47 --- wontfix

People

(Reporter: kats, Assigned: kats)

Details

Right now the nsGfxScrollFrame::ScrollToImpl function takes an nsIAtom* for the origin parameter. However there's no real reason this needs to be an atom rather than an enum with a more specific set of possible values. This is a spinoff from bug 1235899 comment 29.
... and I was wrong. Turns out we do use the string value in the atom, at https://dxr.mozilla.org/mozilla-central/rev/2dfb45d74f42d2a0010696f5fd47c7a7da94cedb/layout/generic/nsGfxScrollFrame.cpp#1747
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.