Closed Bug 1247393 Opened 4 years ago Closed 4 years ago

use arrays of UniquePtr in ChannelEventQueue

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

UniquePtr is nicer/more standard than nsAutoPtr, and using UniquePtr typically
makes the ownership passing more obvious to boot.
Comment on attachment 8718054 [details] [diff] [review]
use arrays of UniquePtr in ChannelEventQueue

Review of attachment 8718054 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

::: netwerk/ipc/ChannelEventQueue.h
@@ +82,5 @@
>    inline void MaybeFlushQueue();
>    void FlushQueue();
>    inline void CompleteResume();
>  
> +  nsTArray<UniquePtr<ChannelEvent>> mEventQueue;

the (windows?) compiler doesn't die anymore if you don't do "> >" ?
Attachment #8718054 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/824e64d7a817
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.