1247393 - use arrays of UniquePtr in ChannelEventQueue

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Nathan Froyd [:froydnj]]

UniquePtr is nicer/more standard than nsAutoPtr, and using UniquePtr typically
makes the ownership passing more obvious to boot.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use arrays of UniquePtr in ChannelEventQueue

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8718054 [details] [diff] [review]
use arrays of UniquePtr in ChannelEventQueue

Review of attachment 8718054 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

::: netwerk/ipc/ChannelEventQueue.h
@@ +82,5 @@
>    inline void MaybeFlushQueue();
>    void FlushQueue();
>    inline void CompleteResume();
>  
> +  nsTArray<UniquePtr<ChannelEvent>> mEventQueue;

the (windows?) compiler doesn't die anymore if you don't do "> >" ?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/824e64d7a817

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/824e64d7a817