Closed Bug 1247396 Opened 5 years ago Closed 4 years ago

Drop support for MOZ_SHARED_ICU

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox47 affected, firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- affected
firefox48 --- fixed

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

We're only using this on Windows, and most of the other usage of it can be replaced with MOZ_SYSTEM_ICU. I don't think there's any reason we need to be doing this on Windows anymore, it's probably a relic of the "linker runs out of address space" woes we used to have.

Getting rid of it will simplify my work in bug 1239083.
Depends on: 926980
Comment on attachment 8718306 [details]
MozReview Request: bug 1247396 - drop support for MOZ_SHARED_ICU. r?glandium

https://reviewboard.mozilla.org/r/34503/#review31359

So much simplifications!
Attachment #8718306 - Flags: review?(mh+mozilla) → review+
No longer depends on: 926980
Thanks, sorry about that. I did build on Windows locally, but I must not have clobbered.
Flags: needinfo?(ted)
https://hg.mozilla.org/mozilla-central/rev/059136c7f6d4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1262492
Depends on: 1262636
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.