Closed Bug 1247396 Opened 5 years ago Closed 4 years ago
Drop support for MOZ
58 bytes, text/x-review-board-request
We're only using this on Windows, and most of the other usage of it can be replaced with MOZ_SYSTEM_ICU. I don't think there's any reason we need to be doing this on Windows anymore, it's probably a relic of the "linker runs out of address space" woes we used to have. Getting rid of it will simplify my work in bug 1239083.
Review commit: https://reviewboard.mozilla.org/r/34503/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34503/
Attachment #8718306 - Flags: review?(mh+mozilla)
Comment on attachment 8718306 [details] MozReview Request: bug 1247396 - drop support for MOZ_SHARED_ICU. r?glandium https://reviewboard.mozilla.org/r/34503/#review31359 So much simplifications!
Attachment #8718306 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e40580ed0fe6fab50f1d8d23747c2cf423d93016 bug 1247396 - drop support for MOZ_SHARED_ICU. r=glandium
I had to back this out because Windows builds were failing like https://treeherder.mozilla.org/logviewer.html#?job_id=24640703&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/4a3ac7d3049c
Thanks, sorry about that. I did build on Windows locally, but I must not have clobbered.
https://hg.mozilla.org/integration/mozilla-inbound/rev/059136c7f6d406f0f5f7cb246aab5ba997a8a939 bug 1247396 - drop support for MOZ_SHARED_ICU. r=glandium
You need to log in before you can comment on or make changes to this bug.