Closed
Bug 1247396
Opened 8 years ago
Closed 8 years ago
Drop support for MOZ_SHARED_ICU
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox47 affected, firefox48 fixed)
RESOLVED
FIXED
mozilla48
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file)
We're only using this on Windows, and most of the other usage of it can be replaced with MOZ_SYSTEM_ICU. I don't think there's any reason we need to be doing this on Windows anymore, it's probably a relic of the "linker runs out of address space" woes we used to have. Getting rid of it will simplify my work in bug 1239083.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/34503/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34503/
Attachment #8718306 -
Flags: review?(mh+mozilla)
Comment 2•8 years ago
|
||
Comment on attachment 8718306 [details] MozReview Request: bug 1247396 - drop support for MOZ_SHARED_ICU. r?glandium https://reviewboard.mozilla.org/r/34503/#review31359 So much simplifications!
Attachment #8718306 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e40580ed0fe6fab50f1d8d23747c2cf423d93016 bug 1247396 - drop support for MOZ_SHARED_ICU. r=glandium
I had to back this out because Windows builds were failing like https://treeherder.mozilla.org/logviewer.html#?job_id=24640703&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/4a3ac7d3049c
Flags: needinfo?(ted)
Assignee | ||
Comment 5•8 years ago
|
||
Thanks, sorry about that. I did build on Windows locally, but I must not have clobbered.
Flags: needinfo?(ted)
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/059136c7f6d406f0f5f7cb246aab5ba997a8a939 bug 1247396 - drop support for MOZ_SHARED_ICU. r=glandium
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/059136c7f6d4
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•