1247403 - Rename tabActive property in Tab component

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1211525

Tab component (used in JSON View and HTTP inspector) is using tabActive property representing index of the default active tab. It should be renamed to activeTab.

Honza

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

The component isn't used in the console anymore (but still is in the JSON viewer).
Let's move this to Shared Component.

Comment 2

[Helena Moreno (aka helenatxu)]

Hello! I'm looking for good-first-bugs to start contributing as I'm applying for the Outreachy internship. Would it be a good one to start with? In that case, I would like to try it.

Comment 3

[Erik Carrillo [:E_Carr]]

(In reply to Nicolas Chevobbe from comment #1)

The component isn't used in the console anymore (but still is in the JSON viewer).
Let's move this to Shared Component.

Hello, I am an Outreachy applicant and would love to be assigned this bug as my first contribution.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Hello ecarr3344, thanks for wanting to help us!
I'm going to assign the bug to you.

You can read http://docs.firefox-dev.tools/getting-started/ to setup your work environment. Make sure to choose Artifact builds when asked to.
Feel free to ask any question, here or on our Slack.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Helenatxu from comment #2)

Hello! I'm looking for good-first-bugs to start contributing as I'm applying for the Outreachy internship. Would it be a good one to start with? In that case, I would like to try it.

Helenatxu, there are other bugs you commented on, that's why I assigned the bug to ecarr3344 instead, I hope it's okay.

Comment 6

[Erik Carrillo [:E_Carr]]

(In reply to Nicolas Chevobbe from comment #4)

Hello ecarr3344, thanks for wanting to help us!
I'm going to assign the bug to you.

You can read http://docs.firefox-dev.tools/getting-started/ to setup your work environment. Make sure to choose Artifact builds when asked to.
Feel free to ask any question, here or on our Slack.

Thank you very much, I will give it my best effort. I am part of the Slack group, which channel is the best to seek help for bug specific questions?

Comment 7

[Helena Moreno (aka helenatxu)]

(In reply to Nicolas Chevobbe from comment #5)

Helenatxu, there are other bugs you commented on, that's why I assigned the bug to ecarr3344 instead, I hope it's okay.

No problem! I asked in a few bugs just in case :) Thank you!

Comment 8

[Erik Carrillo [:E_Carr]]

Attachment: Bug 1247403 - Rename tabActive property to activeTab in the Tab Component. r=Honza

Prior to this change the Tab Component used in JSON View was using the tabActive property representing the index of
the default active tab. This change renamed it to activeTab.

Comment 9

[Erik Carrillo [:E_Carr]]

Attachment: Bug 1247403 - Rename tabActive property to activeTab in the Tab Component. r=Honza

Prior to this change the Tab Component used in JSON View was using the tabActive property representing the index of
the default active tab. This change renamed it to activeTab.

Comment 10

[Erik Carrillo [:E_Carr]]

Attachment: Bug 1247403 - Rename tabActive property to activeTab in the Tab Component. r=Honza

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0ef24484dfe
Rename tabActive property to activeTab in the Tab Component. r=Honza

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c0ef24484dfe