Closed Bug 1247405 Opened 4 years ago Closed 4 years ago

Track peak texture usage

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: snorp, Unassigned)

References

Details

(Whiteboard: gfx-noted,perf)

Attachments

(1 file)

It's becoming apparent that some of our OOM issues could be due to small bursts where we use a lot of texture (and surface) memory. We should not only track the current usage but also the peak.
Whiteboard: gfx-noted,perf
Attachment #8718071 - Flags: review?(nical.bugzilla) → review+
Backed out for bustage:

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/636081f1b332

Bustage example: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e003524530f6
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=22412943&repo=mozilla-inbound

10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:31:27: error: use of deleted function 'mozilla::Atomic<unsigned int>& mozilla::Atomic<unsigned int>::operator=(const mozilla::Atomic<unsigned int>&)'
10:01:18     INFO -  In file included from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.h:10:0,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:7,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/gfx/gl/Unified_cpp_gfx_gl1.cpp:2:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:650:7: note: 'mozilla::Atomic<unsigned int>& mozilla::Atomic<unsigned int>::operator=(const mozilla::Atomic<unsigned int>&)' is implicitly deleted because the default definition would be ill-formed:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:650:7: error: use of deleted function 'mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>& mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>::operator=(const mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>&)'
10:01:18     INFO -  In file included from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.h:10:0,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:7,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/gfx/gl/Unified_cpp_gfx_gl1.cpp:2:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:596:7: note: 'mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>& mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>::operator=(const mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>&)' is implicitly deleted because the default definition would be ill-formed:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:596:7: error: use of deleted function 'mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>& mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>::operator=(const mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>&)'
10:01:18     INFO -  In file included from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.h:10:0,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:7,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/gfx/gl/Unified_cpp_gfx_gl1.cpp:2:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:538:7: note: 'mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>& mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>::operator=(const mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>&)' is implicitly deleted because the default definition would be ill-formed:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:538:7: error: use of deleted function 'std::atomic<unsigned int>& std::atomic<unsigned int>::operator=(const std::atomic<unsigned int>&)'
10:01:18     INFO -  In file included from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/stl_wrappers/atomic:50:0,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:170,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.h:10,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:7,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/gfx/gl/Unified_cpp_gfx_gl1.cpp:2:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.3/../../../../include/c++/4.7.3/atomic:618:15: error: declared here
10:01:18     INFO -  gmake[5]: *** [Unified_cpp_gfx_gl1.o] Error 1
10:01:18     INFO -  gmake[5]: *** Waiting for unfinished jobs....
Flags: needinfo?(snorp)
Thanks
Flags: needinfo?(snorp)
https://hg.mozilla.org/mozilla-central/rev/fe64e32bb4fb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.