1247405 - Track peak texture usage

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

It's becoming apparent that some of our OOM issues could be due to small bursts where we use a lot of texture (and surface) memory. We should not only track the current usage but also the peak.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Track peak texture memory usage

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ee7b97a8a84

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for bustage:

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/636081f1b332

Bustage example: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e003524530f6
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=22412943&repo=mozilla-inbound

10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:31:27: error: use of deleted function 'mozilla::Atomic<unsigned int>& mozilla::Atomic<unsigned int>::operator=(const mozilla::Atomic<unsigned int>&)'
10:01:18     INFO -  In file included from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.h:10:0,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:7,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/gfx/gl/Unified_cpp_gfx_gl1.cpp:2:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:650:7: note: 'mozilla::Atomic<unsigned int>& mozilla::Atomic<unsigned int>::operator=(const mozilla::Atomic<unsigned int>&)' is implicitly deleted because the default definition would be ill-formed:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:650:7: error: use of deleted function 'mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>& mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>::operator=(const mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>&)'
10:01:18     INFO -  In file included from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.h:10:0,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:7,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/gfx/gl/Unified_cpp_gfx_gl1.cpp:2:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:596:7: note: 'mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>& mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>::operator=(const mozilla::detail::AtomicBaseIncDec<unsigned int, (mozilla::MemoryOrdering)2u>&)' is implicitly deleted because the default definition would be ill-formed:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:596:7: error: use of deleted function 'mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>& mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>::operator=(const mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>&)'
10:01:18     INFO -  In file included from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.h:10:0,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:7,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/gfx/gl/Unified_cpp_gfx_gl1.cpp:2:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:538:7: note: 'mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>& mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>::operator=(const mozilla::detail::AtomicBase<unsigned int, (mozilla::MemoryOrdering)2u>&)' is implicitly deleted because the default definition would be ill-formed:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:538:7: error: use of deleted function 'std::atomic<unsigned int>& std::atomic<unsigned int>::operator=(const std::atomic<unsigned int>&)'
10:01:18     INFO -  In file included from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/stl_wrappers/atomic:50:0,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/dist/include/mozilla/Atomics.h:170,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.h:10,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/gl/GfxTexturesReporter.cpp:7,
10:01:18     INFO -                   from /builds/slave/m-in-lx-0000000000000000000000/build/src/obj-firefox/gfx/gl/Unified_cpp_gfx_gl1.cpp:2:
10:01:18     INFO -  /builds/slave/m-in-lx-0000000000000000000000/build/src/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.3/../../../../include/c++/4.7.3/atomic:618:15: error: declared here
10:01:18     INFO -  gmake[5]: *** [Unified_cpp_gfx_gl1.o] Error 1
10:01:18     INFO -  gmake[5]: *** Waiting for unfinished jobs....

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Thanks

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe64e32bb4fb

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fe64e32bb4fb