resurrecting a service worker registration fails to persist registration to disk

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

(Blocks 1 bug)

32 Branch
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

We used to call StoreRegistration() immediately at the start of a register job.  I removed this, though, because storing a registration for a service worker that may fail to install did not make sense.

Doing this, though, introduced another bug.  If we resurrect an existing registration by clearing its uninstalling flag, then we can now end up with a live registration that is not persisted to disk.  We should call StoreRegistration() iff we flip mPendingUninstall from true to false in the register job.
(Assignee)

Updated

3 years ago
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Attachment #8718104 - Flags: review?(amarchesini) → review+

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8b52a9d0e410
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.