Closed
Bug 1247445
Opened 5 years ago
Closed 5 years ago
Rename Layer::GetEffectiveVisibleRegion to GetLocalVisibleRegion
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: botond, Assigned: mds, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [gfx-noted] [lang=c++] [good first bug])
Attachments
(1 file, 1 obsolete file)
29.25 KB,
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
This will make the naming more consistent, as described in bug 1247442 comment 1.
Reporter | ||
Updated•5 years ago
|
Whiteboard: [gfx-noted] [lang=c++] → [gfx-noted] [lang=c++] [good first bug]
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → michelangelo
Status: NEW → ASSIGNED
Assignee | ||
Updated•5 years ago
|
Attachment #8719125 -
Flags: review?(botond)
Reporter | ||
Comment 2•5 years ago
|
||
Comment on attachment 8719125 [details] [diff] [review] Layer::GetEffectiveVisibleRegion renamed to GetLocalVisibleRegion Review of attachment 8719125 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, Michelangelo! There is one call site you missed, in widget/gonk/HwcComposer2D.cpp [1]. You can do a DXR search to see all call sites [2]. Could you upload a patch with that call site changed as well? Thanks! [1] https://dxr.mozilla.org/mozilla-central/source/widget/gonk/HwcComposer2D.cpp#283 [2] https://dxr.mozilla.org/mozilla-central/search?q=GetEffectiveVisibleRegion
Attachment #8719125 -
Flags: review?(botond) → feedback+
Assignee | ||
Updated•5 years ago
|
Attachment #8719125 -
Attachment is obsolete: true
Reporter | ||
Comment 4•5 years ago
|
||
Comment on attachment 8719222 [details] [diff] [review] Layer::GetEffectiveVisibleRegion renamed to GetLocalVisibleRegion Review of attachment 8719222 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8719222 -
Flags: review?(botond) → review+
Reporter | ||
Comment 5•5 years ago
|
||
Landed on mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/089caa319fc9
Assignee | ||
Comment 6•5 years ago
|
||
Thanks!
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/089caa319fc9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•