1247462 - Support running tests in git clones of vct

Status: NEW

(Developer Services :: General, task)

Description

[Mike Hommey [:glandium]]

Turns out the patch I attached in bug 1247172 works.

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1247462 - Support running tests in git clones of vct. r=gps

Review commit: https://reviewboard.mozilla.org/r/34423/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34423/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8718127 [details]
MozReview Request: Bug 1247462 - Support running tests in git clones of vct. r=gps

https://reviewboard.mozilla.org/r/34423/#review31293

I am reluctant to support version-control-tools as a Git repo for all the tests. The main reason is various parts of the Ansible configuration assume version-control-tools is a Mercurial repo. I would rather we not add complexity to the automation configs for a scenario that will never exist in production.

It is more than reasonable to detect a Git version-control-tools and abort gracefully. I think it is also reasonable for some tests (notably the ones not using Docker) to run from a Git version-control-tools.

While this patch is a step in the right direction, I'm pretty certain several tests will still fail when run under Git. If you are going to claim to support Git v-c-t, I'd like us to fail faster when we know tests won't work with Git v-c-t.

Comment 3

[Mike Hommey [:glandium]]

The git/tests tests, which require docker, do work with this patch. IIUC (but really, I'm essentially clueless), all the things using .vctnode are actually pulling from the canonical mercurial repo instead of the local clone, so that should work too. That's also why I'm changing the mercurial -r argument.

Comment 4

[Mike Hommey [:glandium]]

I am, indeed, getting plenty of errors when running the complete test suite, but it's hard to tell whether they're related to running from a git repository or because of some other fuckup. I wouldn't be shocked if it were the latter, considering my experience with this test suite.

That said, it's also not far fetched that people running git mozreview and trying to run its tests would be cloning vct with git...