Closed Bug 1247482 Opened 8 years ago Closed 8 years ago

Startup crash on version 2.0 (2004) with -whole-module-optimization

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios-v2.0 --- fixed
fxios 2.0+ ---

People

(Reporter: aaronmt, Assigned: rnewman)

References

Details

Attachments

(1 file)

Pull req.
48 bytes, text/x-github-pull-request
sleroux
: review+
st3fan
: review+
bnicholson
: review+
Details | Review 
      No description provided.
Feb 10 19:26:59 Aaron-Trains-iPhone SpringBoard[58] <Error>:  SecTrustEvaluate  [leaf IssuerCommonName SubjectCommonName]
Feb 10 19:26:59 Aaron-Trains-iPhone SpringBoard[58] <Error>:  SecTrustEvaluate  [leaf IssuerCommonName SubjectCommonName]
Feb 10 19:26:59 Aaron-Trains-iPhone kernel[0] <Notice>: xpcproxy[293] Container: /private/var/mobile/Containers/Data/Application/87208DF0-D202-452A-BC87-89B3E61CB3D5 (sandbox)
Feb 10 19:26:59 Aaron-Trains-iPhone Client[293] <Warning>: 	[Adjust]a: PRODUCTION: Adjust is running in Production mode. Use this setting only for the build that you want to publish. Set the environment to `sandbox` if you want to test your app!
Feb 10 19:27:19 Aaron-Trains-iPhone SpringBoard[58] <Warning>: Forcing crash report of <FBApplicationProcess: 0x15fc58440; Client; pid: 293> (reason: 1, description: org.mozilla.ios.Firefox failed to scene-create after 19.91s (launch took 0.09s of total time limit 20.00s))
Feb 10 19:27:19 Aaron-Trains-iPhone diagnosticd[85] <Error>: error evaluating process info - pid: 293, punique: 293
Feb 10 19:27:19 Aaron-Trains-iPhone SpringBoard[58] <Warning>: Finished crash reporting.
Feb 10 19:27:19 Aaron-Trains-iPhone SpringBoard[58] <Warning>: BSXPCMessage received error for message: Connection invalid
Feb 10 19:27:19 Aaron-Trains-iPhone SpringBoard[58] <Warning>: BSXPCMessage received error for message: Connection invalid
Feb 10 19:27:19 Aaron-Trains-iPhone SpringBoard[58] <Warning>: HW kbd: Failed to set (null) as keyboard focus
Feb 10 19:27:19 Aaron-Trains-iPhone mediaserverd[28] <Notice>: '' org.mozilla.ios.Firefox(pid = 293) setting DiscoveryMode = DiscoveryMode_None, currentDiscoveryMode = DiscoveryMode_None
Feb 10 19:27:19 Aaron-Trains-iPhone com.apple.xpc.launchd[1] (UIKitApplication:org.mozilla.ios.Firefox[0xfa1f][293]) <Notice>: Service exited due to signal: Killed: 9
Feb 10 19:27:19 Aaron-Trains-iPhone ReportCrash[294] <Warning>: saved type '109_Client' report (1 of max 25) as /var/mobile/Library/Logs/CrashReporter/Client_2016-02-10-192719_Aaron-Trains-iPhone.ips.beta
Feb 10 19:27:19 Aaron-Trains-iPhone SpringBoard[58] <Warning>: Application 'UIKitApplication:org.mozilla.ios.Firefox[0xfa1f]' exited abnormally via signal.
Feb 10 19:27:19 Aaron-Trains-iPhone UserEventAgent[26] <Warning>: 21676329626: id=org.mozilla.ios.Firefox pid=293, state=0
Feb 10 19:27:20 Aaron-Trains-iPhone duetexpertd[158] <Warning>: Error loading default properties for object x-apple-eventkit:///Event/p5833 from daemon: Error Domain=EKCADErrorDomain Code=1013 "(null)"
Feb 10 19:27:20 Aaron-Trains-iPhone duetexpertd[158] <Warning>: Error loading default properties for object x-apple-eventkit:///Event/p5833 from daemon: Error Domain=EKCADErrorDomain Code=1013 "(null)"
Feb 10 19:27:20 Aaron-Trains-iPhone duetexpertd[158] <Warning>: Error loading default properties for object x-apple-eventkit:///Event/p5833 from daemon: Error Domain=EKCADErrorDomain Code=1013 "(null)"
Feb 10 19:27:20 Aaron-Trains-iPhone duetexpertd[158] <Warning>: Error loading to-many relation attendees from daemon: Error Domain=EKCADErrorDomain Code=1013 "(null)"
Feb 10 19:27:20 Aaron-Trains-iPhone searchd[149] <Warning>: ====^^^^ DuetExpert missing data, count -> people:2 applicationDeepLinks:0 applications:8 requests:11 missingAllDataRequests:0
iPad

eb 10 19:30:37 Aaron-Trains-iPad SpringBoard[53] <Error>:  SecTrustEvaluate  [leaf IssuerCommonName SubjectCommonName]
Feb 10 19:30:37 Aaron-Trains-iPad SpringBoard[53] <Error>:  SecTrustEvaluate  [leaf IssuerCommonName SubjectCommonName]
Feb 10 19:30:37 Aaron-Trains-iPad kernel[0] <Notice>: xpcproxy[351] Container: /private/var/mobile/Containers/Data/Application/FE67821C-8C18-4FC4-92EA-214E7BE01FBC (sandbox)
Feb 10 19:30:37 Aaron-Trains-iPad Client[351] <Warning>: 	[Adjust]a: PRODUCTION: Adjust is running in Production mode. Use this setting only for the build that you want to publish. Set the environment to `sandbox` if you want to test your app!
Feb 10 19:30:38 Aaron-Trains-iPad SpringBoard[53] <Warning>: BSXPCMessage received error for message: Connection interrupted
Feb 10 19:30:38 Aaron-Trains-iPad SpringBoard[53] <Warning>: BSXPCMessage received error for message: Connection invalid
Feb 10 19:30:38 Aaron-Trains-iPad SpringBoard[53] <Warning>: HW kbd: Failed to set (null) as keyboard focus
Feb 10 19:30:38 Aaron-Trains-iPad mediaserverd[25] <Notice>: '' org.mozilla.ios.Firefox(pid = 351) setting DiscoveryMode = DiscoveryMode_None, currentDiscoveryMode = DiscoveryMode_None
Feb 10 19:30:38 Aaron-Trains-iPad com.apple.xpc.launchd[1] (UIKitApplication:org.mozilla.ios.Firefox[0x1e59][351]) <Warning>: Service exited with abnormal code: 1
Feb 10 19:30:38 Aaron-Trains-iPad SpringBoard[53] <Warning>: Application 'UIKitApplication:org.mozilla.ios.Firefox[0x1e59]' exited voluntarily.
Feb 10 19:30:38 Aaron-Trains-iPad kernel[0] <Notice>: xpcproxy[353] Container: /private/var/mobile/Containers/Data/Application/FE67821C-8C18-4FC4-92EA-214E7BE01FBC (sandbox)
Feb 10 19:30:38 Aaron-Trains-iPad UserEventAgent[23] <Warning>: 281868001424: id=org.mozilla.ios.Firefox pid=351, state=0
Feb 10 19:30:38 Aaron-Trains-iPad Client[353] <Warning>: 	[Adjust]a: PRODUCTION: Adjust is running in Production mode. Use this setting only for the build that you want to publish. Set the environment to `sandbox` if you want to test your app!
Feb 10 19:30:58 Aaron-Trains-iPad SpringBoard[53] <Warning>: Forcing crash report of <FBApplicationProcess: 0x1313d6200; Client; pid: 353> (reason: 1, description: org.mozilla.ios.Firefox failed to scene-create after 19.93s (launch took 0.07s of total time limit 20.00s))
Feb 10 19:30:58 Aaron-Trains-iPad diagnosticd[80] <Error>: error evaluating process info - pid: 353, punique: 353
Feb 10 19:30:58 Aaron-Trains-iPad SpringBoard[53] <Warning>: Finished crash reporting.
Feb 10 19:30:58 Aaron-Trains-iPad SpringBoard[53] <Warning>: BSXPCMessage received error for message: Connection invalid
Feb 10 19:30:58 Aaron-Trains-iPad SpringBoard[53] <Warning>: HW kbd: Failed to set (null) as keyboard focus
Feb 10 19:30:58 Aaron-Trains-iPad SpringBoard[53] <Warning>: Unable to get short BSD proc info for 353: No such process
Feb 10 19:30:58 Aaron-Trains-iPad SpringBoard[53] <Warning>: Unable to get short BSD proc info for 353: No such process
Feb 10 19:30:58 Aaron-Trains-iPad mediaserverd[25] <Notice>: '' org.mozilla.ios.Firefox(pid = 353) setting DiscoveryMode = DiscoveryMode_None, currentDiscoveryMode = DiscoveryMode_None
Feb 10 19:30:58 Aaron-Trains-iPad com.apple.xpc.launchd[1] (UIKitApplication:org.mozilla.ios.Firefox[0xa083][353]) <Notice>: Service exited due to signal: Killed: 9
Feb 10 19:30:58 Aaron-Trains-iPad ReportCrash[354] <Warning>: saved type '109_Client' report (1 of max 25) as /var/mobile/Library/Logs/CrashReporter/Client_2016-02-10-193058_Aaron-Trains-iPad.ips.beta
Feb 10 19:30:58 Aaron-Trains-iPad SpringBoard[53] <Warning>: Application 'UIKitApplication:org.mozilla.ios.Firefox[0xa083]' exited abnormally via signal.
Feb 10 19:30:58 Aaron-Trains-iPad UserEventAgent[23] <Warning>: 282355259959: id=org.mozilla.ios.Firefox pid=353, state=0
Random thoughts:

• What did we land between the last good build and this one. Can anyone do some git magic on that?
• We time out, could this be database?
• Is this the first build with Xcode 7.2.1?
• Why does this happen on TestFlight and not on a local development build.
It prints "Adjust is running in Production mode." so whatever is causing this must happen after that.
I created an L10N Aurora build from the v2.x branch and it crashes in the same way.

https://people.mozilla.org/iosbuilds/l10n.html
I got some logging going on a build that crashes:

Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Configuring window…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Setting UA…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Starting keyboard helper…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Starting dynamic font helper…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Setting custom menu items…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Creating Sync log file…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Creating corrupt DB logger…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Creating Browser log file…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Getting profile…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Starting web server…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Setting AVAudioSession category…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Configuring tabManager…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Initing BVC…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Configuring Breakpad…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Adding observers…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Done with setting up the application.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Did finish launching.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Setting up Adjust
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Making window key and visible…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Triggering log roll.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Done with applicationDidFinishLaunching.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Loading queued tabs in the background.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC viewDidLoad…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC super viewDidLoad called.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC adding footer and header…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC setting up webViewContainer…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC setting up status bar…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC setting up top touch area…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC setting up URL bar…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC setting up search loader…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC updating toolbar state…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC setting up constraints…
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC done.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC viewWillAppear.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC super.viewWillAppear done.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: Restoring tabs.
Feb 10 21:13:33 Stefan-Arentzs-iPhone Client[863] <Warning>: BVC showHomePanelController.

Feb 10 21:13:46 Stefan-Arentzs-iPhone SpringBoard[58] <Warning>: Forcing crash report of <FBApplicationProcess: 0x162265780; Client; pid: 863> (reason: 1, description: org.mozilla.ios.FennecAurora failed to scene-create after 13.61s (launch took 6.39s of total time limit 20.00s))

BrowserViewConroller.showHomePanelController() prints both at function entry and exit. It never exits. This must be a good hint.

Was anything changed recently that is called from showHomePanelController() ?
May be a red herring ... because now we get killed at:

Feb 10 21:20:37 Stefan-Arentzs-iPhone Client[872] <Warning>: Configuring window…
Feb 10 21:20:37 Stefan-Arentzs-iPhone Client[872] <Warning>: Setting UA…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Starting keyboard helper…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Starting dynamic font helper…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Setting custom menu items…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Creating Sync log file…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Creating corrupt DB logger…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Creating Browser log file…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Getting profile…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Starting web server…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Setting AVAudioSession category…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Configuring tabManager…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Initing BVC…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Configuring Breakpad…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Adding observers…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Done with setting up the application.
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Did finish launching.
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Setting up Adjust
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Making window key and visible…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Triggering log roll.
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Done with applicationDidFinishLaunching.
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: Loading queued tabs in the background.
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: BVC viewDidLoad…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: BVC super viewDidLoad called.
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: BVC adding footer and header…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: BVC setting up webViewContainer…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: BVC setting up status bar…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: BVC setting up top touch area…
Feb 10 21:20:38 Stefan-Arentzs-iPhone Client[872] <Warning>: BVC setting up URL bar…
So could be timing related?
Removed Adjust. No change.
New build with Swift Code Optimization (SWIFT_OPTIMIZATION_LEVEL) set to -Onone

Works fine.

Two suggestions:

1) Maybe we can try to do an optimized build with Xcode 7.2 to see if that makes a difference. I think the last build we did was with 7.2?

2) Ship with -Onone

:-(
Last update before I sign off: I tested with Xcode 7.2 and it has the same behaviour:

App compiled with -Onone starts fine
App compiled with -O -whole-module-optimization hangs

So lets ship an unoptimized binary!
Final update: The problem is -whole-module-optimization.

SWIFT_OPTIMIZATION_LEVEL set to just -O gives us a good binary.
Summary: Startup crash on version 2.0 (2004) → Startup crash on version 2.0 (2004) with -whole-module-optimization
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attached file Pull req. — 
Have at. Note the project file change. You might need to revert 95cdde6 in order to test.
Attachment #8718404 - Flags: review?(sleroux)
Attachment #8718404 - Flags: review?(sarentz)
Attachment #8718404 - Flags: review?(bnicholson)
Comment on attachment 8718404 [details] [review]
Pull req.

Don't really understand what's going on, but if it works it works!
Attachment #8718404 - Flags: review?(bnicholson) → review+
Comment on attachment 8718404 [details] [review]
Pull req.

Looks good and works for me as well!
Attachment #8718404 - Flags: review?(sleroux) → review+
2898b98
status-fxios-v2.0: --- → fixed
master: 9eb4084
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0
Attachment #8718404 - Flags: review?(sarentz) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: