bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Implement the `tabId` property of browser.windows.create

RESOLVED FIXED in Firefox 47

Status

WebExtensions
Untriaged
RESOLVED FIXED
3 years ago
26 days ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks: 1 bug)

unspecified
mozilla47

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: [windows])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8718584 [details]
MozReview Request: Bug 1247493: [webext] Implement the `tabId` property of windows.create. r?billm

Review commit: https://reviewboard.mozilla.org/r/34631/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34631/
Attachment #8718584 - Flags: review?(wmccloskey)

Updated

2 years ago
Whiteboard: [windows]
Comment on attachment 8718584 [details]
MozReview Request: Bug 1247493: [webext] Implement the `tabId` property of windows.create. r?billm

https://reviewboard.mozilla.org/r/34631/#review31833

::: browser/components/extensions/ext-windows.js:78
(Diff revision 1)
> +          if (createData.incognito !== null) {

If this is in agreement with the tab's incognito status, I feel like we shouldn't reject. Do you know what Chrome does?
Attachment #8718584 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 3

2 years ago
https://reviewboard.mozilla.org/r/34631/#review31833

> If this is in agreement with the tab's incognito status, I feel like we shouldn't reject. Do you know what Chrome does?

Yeah, I thought about that. I don't really have a strong opinion on it, but I'd prefer that people not specify it when moving tabs.

That said, Chrome allows creating a new incognito window with a non-incognito tab, or vise versa, but the tabs keep their previous `incognito` property. I don't think we should try to do the same. We have a few tests to prevent dragging tabs from one window type to another, and it seems like the correct behavior.

Chrome also doesn't take the type of the tab's current window into account when creating that window, though, so add-ons would need to pass `{ incognito: tab.incognito }` to do it correctly there. So I guess we should allow it as well.
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/cf766413a25e77d31495f2b6e7d38e1d1bb40603
Bug 1247493: [webext] Implement the `tabId` property of windows.create. r=billm
I had to back this out because either it or one of the other patches pushed together broke some tests: https://treeherder.mozilla.org/logviewer.html#?job_id=7363470&repo=fx-team

https://hg.mozilla.org/integration/fx-team/rev/2a46feffefcc
Flags: needinfo?(kmaglione+bmo)
(Assignee)

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/edeaf23bea8655f3b03612bf8743edd8c592a263
Bug 1247493: [webext] Implement the `tabId` property of windows.create. r=billm
(Assignee)

Updated

2 years ago
Flags: needinfo?(kmaglione+bmo)

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/edeaf23bea86
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Updated

26 days ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.