1247514 - Intermittent 41276-1.html,408431-1.html | application crashed [@ SpeechTaskCallback::OnWillSpeakWord(unsigned int)]

Status: RESOLVED FIXED

(Core :: Web Speech, defect)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=21452961&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=21465432&repo=mozilla-inbound

Comment 1

[Intermittent Failures Robot]

6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 6

Platform breakdown:
* osx-10-10: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1247514&startday=2016-02-08&endday=2016-02-14&tree=all

Comment 2

[Makoto Kato [:m_kato]]

By bug 1230533, when navigating to another page, speech is canceled.  (crash test calls cancel method, also).  I need investigate why OSX synthesizer doesn't cancel it well.

Comment 3

[Intermittent Failures Robot]

14 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* fx-team: 8
* mozilla-inbound: 4
* mozilla-central: 2

Platform breakdown:
* osx-10-10: 12
* osx-10-6: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1247514&startday=2016-02-22&endday=2016-02-28&tree=all

Comment 4

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7c53ed2a24a

Comment 5

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1247514 - Clear speech delegate when finishing speaking. r?eeejay

After dispatched didFinishSpeaking by OS, another events may be dispatched.  So I should remove speech delegate soon when didFinishSpeaking is called.

Review commit: https://reviewboard.mozilla.org/r/37777/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37777/

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8726043 [details]
MozReview Request: Bug 1247514 - Clear speech delegate when finishing speaking. r?eeejay

https://reviewboard.mozilla.org/r/37777/#review34841

This is great!

Comment 7

[Intermittent Failures Robot]

10 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 6
* fx-team: 4

Platform breakdown:
* osx-10-10: 9
* osx-10-6: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1247514&startday=2016-02-29&endday=2016-03-06&tree=all

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b9a16cc88c2

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4b9a16cc88c2

Comment 10

[Makoto Kato [:m_kato]]

no crash after landing.  I close this.