Closed
Bug 1247533
Opened 8 years ago
Closed 8 years ago
Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in layout/style/
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional. layout/style/nsStyleTransformMatrix.cpp:642:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8718227 -
Flags: review?(wchen)
|
Assignee | |
Updated•8 years ago
|
status-firefox47:
--- → affected
Summary: Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough in layout/style/ → Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in layout/style/
Attachment #8718227 -
Flags: review?(wchen) → review+
Component: DOM: CSS Object Model → CSS Parsing and Computation
|
||
Comment 2•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/09f9cbdd1403
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•