1247547 - WEBRTC_ICE_ADD_CANDIDATE* reports errors twice

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Comment 1

[Nils Ohlmeier [:drno]]

Bug 1091242 moved the error counter into a new place without removing the old counter, thus the error counter |mAddCandidateErrorCount| gets increased twice since that bug landed in 37.

Comment 2

[Nils Ohlmeier [:drno]]

Attachment: MozReview Request: Bug 1247547: removed double accounting for WEBRTC_ICE_ADD_CANDIDATE telemetry probes. r=bwc

Review commit: https://reviewboard.mozilla.org/r/34481/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34481/

Comment 3

[Byron Campen [:bwc]]

Comment on attachment 8718270 [details]
MozReview Request: Bug 1247547: removed double accounting for WEBRTC_ICE_ADD_CANDIDATE telemetry probes. r=bwc

https://reviewboard.mozilla.org/r/34481/#review31199

::: media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h:622
(Diff revision 1)
> -  void OnAddIceCandidateError() {
> +  void OnAddIceCandidateError();

I don't think anything actually calls this. It can be removed entirely.

Fortunately this means any telemetry we have isn't polluted.

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8718270 [details]
MozReview Request: Bug 1247547: removed double accounting for WEBRTC_ICE_ADD_CANDIDATE telemetry probes. r=bwc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34481/diff/1-2/

Comment 5

[Nils Ohlmeier [:drno]]

https://reviewboard.mozilla.org/r/34481/#review31199

> I don't think anything actually calls this. It can be removed entirely.
> 
> Fortunately this means any telemetry we have isn't polluted.

You are right. I mis-interpreted the call to OnAddIceCandidateError() here https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#2064 to be calling this.

Removed the function all together.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32be2fe53fcd

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/32be2fe53fcd