59 bytes, text/x-review-board-request
With bug 1224450 filling the CompileDB from moz.build instead of showbuild in an idempotent way, it means it has the same flaws. And one of them is that the showbuild-based CompileDB didn't know about file-specific flags. Which moz.build knows about, so it's now possible to add them.
Comment on attachment 8858441 [details] Bug 1247567 - Include per-source flags in the CompileDB. https://reviewboard.mozilla.org/r/130410/#review133264 Some unit tests might be welcome, but I don't think we have any existing test for the compiledb :(.
Attachment #8858441 - Flags: review?(mh+mozilla) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/aa88fe80b1d0 Include per-source flags in the CompileDB. r=glandium
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.