Closed Bug 1247567 Opened 7 years ago Closed 6 years ago

Add missing file-specific compile flags to CompileDB

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

With bug 1224450 filling the CompileDB from moz.build instead of showbuild in an idempotent way, it means it has the same flaws. And one of them is that the showbuild-based CompileDB didn't know about file-specific flags. Which moz.build knows about, so it's now possible to add them.
Blocks: fastermake
Comment on attachment 8858441 [details]
Bug 1247567 - Include per-source flags in the CompileDB.

https://reviewboard.mozilla.org/r/130410/#review133264

Some unit tests might be welcome, but I don't think we have any existing test for the compiledb :(.
Attachment #8858441 - Flags: review?(mh+mozilla) → review+
Assignee: nobody → cmanchester
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa88fe80b1d0
Include per-source flags in the CompileDB. r=glandium
https://hg.mozilla.org/mozilla-central/rev/aa88fe80b1d0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.