Add missing file-specific compile flags to CompileDB

RESOLVED FIXED in Firefox 55

Status

RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: glandium, Assigned: chmanchester)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
With bug 1224450 filling the CompileDB from moz.build instead of showbuild in an idempotent way, it means it has the same flaws. And one of them is that the showbuild-based CompileDB didn't know about file-specific flags. Which moz.build knows about, so it's now possible to add them.
(Reporter)

Updated

3 years ago
Blocks: 1241743
Comment hidden (mozreview-request)
(Reporter)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8858441 [details]
Bug 1247567 - Include per-source flags in the CompileDB.

https://reviewboard.mozilla.org/r/130410/#review133264

Some unit tests might be welcome, but I don't think we have any existing test for the compiledb :(.
Attachment #8858441 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

2 years ago
Assignee: nobody → cmanchester

Comment 3

2 years ago
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa88fe80b1d0
Include per-source flags in the CompileDB. r=glandium

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aa88fe80b1d0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

11 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.