1247569 - List of commits to land grows out of viewport

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Andreas Tolfsen ❲:ato❳]

When you have a small screen and a lot of child reviews, the list of commits to land when invoking autoland-to-inbound is too long to fit inside the viewport.

I am only able to land my review by deleting nodes through the devtools inspector.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Screen Shot 2016-02-11 at 12.27.57.png

Please see attached screenshot.

Comment 2

[:glob ✱]

Attachment: MozReview Request: autoland: set a max height on the commit confirmation dialog (bug 1247569) r?dminor

djblet's modal box doesn't restrict the height of content to the window,
resulting in a dialog with unreadable content when there are a lot of commits.
Unfortunately fixing this correctly by bounding the dialog to the window isn't
possible with RB css, so we just cap the maximum height at 600px.

Review commit: https://reviewboard.mozilla.org/r/34549/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34549/

Comment 3

[Dan Minor [:dminor]]

Comment on attachment 8718385 [details]
MozReview Request: autoland: set a max height on the commit confirmation dialog (bug 1247569) r?dminor

https://reviewboard.mozilla.org/r/34549/#review31233

lgtm

Comment 4

[:glob ✱]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/02aec36de661