124762 - [FIX]Save Link As Doesn't Work On FTP

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Brett Denny]

Save Link As... in the context menu won't work for FTP listings, but only when
"Enable html directory listing" is *unchecked* under the debug menu in
preferences.  Viewing an html listing with this checked or unchecked works still.

Steps to reproduce:
1.  Uncheck "Enable html directory listing" in Edit|Preferences|Debug|Networking
2.  Go to ftp://ftp.mozilla.org/pub/mozilla/nightly/latest-trunk
3.  Right click on one of the files and click "Save Link As..."

Expected result:
Save as dialog comes up

Actual result:
Nothing happens.  Note, if you go to
http://ftp.mozilla.org/pub/mozilla/nightly/latest-trunk and click on "Save Link
As..." in the context menu, it'll work fine.

Comment 1

[Bradley Baetz (:bbaetz)]

-> file handing

Error: this.link.getAttribute is not a function
Source File: chrome://communicator/content/nsContextMenu.js
Line: 583

Comment 2

[Bradley Baetz (:bbaetz)]

Really to file handling

Comment 3

[Boris Zbarsky [:bzbarsky]]

wait... Why's this.link.getAttribute not a function?  Isn't this.link a node?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: proposed patch

A little hacky, but it works...

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 68820 [details] [diff] [review]
proposed patch

hacks-r-us

r=bbaetz

Comment 6

[jag (Peter Annema)]

Comment on attachment 68820 [details] [diff] [review]
proposed patch

sr=jag

Comment 7

[Boris Zbarsky [:bzbarsky]]

taking this to check in

Comment 8

[Boris Zbarsky [:bzbarsky]]

checked in.

Comment 9

[sairuh (rarely reading bugmail)]

well, as of today's build (2002.04.09 comm), i don't get a context menu at all
when my ftp listing uses the xul format. filed bug 136490 for that --although
imho i'd rather see bug 102812 fixed...

Comment 10

[sairuh (rarely reading bugmail)]

rs vrfy --see bug 136490 for the lack-of-context-menu issue...