Closed
Bug 1247644
Opened 5 years ago
Closed 5 years ago
Instantly get rid of unreferenced and doomed HTTP cache entries
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: mayhemer, Assigned: mayhemer)
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
19.77 KB,
patch
|
michal
:
review+
|
Details | Diff | Splinter Review |
+also drop any I/O on them (except closing/erasing a file when present and not after shutdown) When CacheEntry::mHandlesCount == 0 && mIsDoomed -> tell the cache file to "kill" itself instantly (= no (meta)data writes, just wipe the file existence, if there has even been a file physically open).
Updated•5 years ago
|
Whiteboard: [necko-active]
![]() |
Assignee | |
Comment 1•5 years ago
|
||
The main motivation here is the Skype bug 1215970. But according the most recent findings, this may not be an immediate problem, turning this bug to just a small optimization.
![]() |
Assignee | |
Comment 2•5 years ago
|
||
Tho... I can see this happening often enough to get my attention when scrolling timelines on facebook. So, it may be worth doing.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 3•5 years ago
|
||
- CacheFileIOListener has a new virtual getter IsKilled - that one is reimplemented by CacheFile - returns true after last outer reference to CacheEntry has been released and that entry has also been doomed - most of the operations of IO manager check for this flag being set (on main thread and in *Internal parts, and if killed, open, truncate, read and write are completely bypassed - cache file input stream now also keeps an outer reference to its cache entry so that we don't kill a file whom input stream is life This saves doing IO (mainly early metadata write) on cache files that will never be used (are unreachable and doomed). Among other patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee1b8b5b1464
Attachment #8719042 -
Flags: review?(michal.novotny)
![]() |
Assignee | |
Comment 4•5 years ago
|
||
Better try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8468c928d0e2
Updated•5 years ago
|
Attachment #8719042 -
Flags: review?(michal.novotny) → review+
![]() |
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
![]() |
Assignee | |
Updated•5 years ago
|
Whiteboard: [necko-would-take] → [necko-active]
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/74c396a8252c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•