1247665 - Unable to save an image from a webpage

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Max Ivanov[:MaxIvanov]]

It is unable to save an image. Tapping on the 'save image' button has no effect

Repro Steps:
1) Update a Aries to 20160211141307
2) Open the browser app
3) Navigate to the google.com -> images and query any image
4) Open an image, tap and hold on it, tap on 'save image' button

Actual:
Nothing happens

Expected:
The image saves to the sdcard, user is notified by sound and notification toast

Environmental Variables:
Device: Aries 2.6
Build ID: 20160211141307
Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c
Gecko: 904f3554c08488c53d24deb20a486600ddddd56b
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 46.0a1 (2.6)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Repro frequency: (100%)
See attached: (video clip, logcat)

Comment 1

[Max Ivanov[:MaxIvanov]]

This also happens on the latest Flame 2.6 
Nothing happens,tapping on the 'save image' button has no effect

Device: Flame 2.6
Build ID: 20160211030205
Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c
Gecko: d4d72e7b30da251ad3027e234444251adad5e335
Gonk: 8a066f7fa7410e32b58def35f322aa33f03db283
Version: 46.0a1 (2.6)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

This does NOT happen on the latest Flame 2.5
The image saves to the sdcard, user is notified by sound and notification toast

Device: Flame 2.5
Build ID: 20160208174403
Gaia: 28880004bc5cd6e129d0a23b701a389753788ed0
Gecko: 4ee75807aba47e9176644ec5cd498c8ff73ac08a
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 2

[Max Ivanov[:MaxIvanov]]

Attachment: logs.txt

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1232901 seems to have caused this issue.

Mozilla-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.6
BuildID: 20160210144039
Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c
Gecko: 0ca917b25c1beaabb608628d209027a0b9618527
Version: 46.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

First Broken 
Environmental Variables:
Device: Flame 2.6
BuildID: 20160210145439
Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c
Gecko: 0f2a2b6bbf6291cd48a35edc189e5556116c3e0a
Version: 46.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Last Working gaia / First Broken gecko - Issue DOES occur
Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c
Gecko: 0f2a2b6bbf6291cd48a35edc189e5556116c3e0a

First Broken gaia / Last Working gecko - Issue does NOT occur
Gaia: 4f0e2a1a42a2d049b6fe8f4f095cdcdf0fd5465c
Gecko: 0ca917b25c1beaabb608628d209027a0b9618527

Gaia Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0ca917b25c1beaabb608628d209027a0b9618527&tochange=0f2a2b6bbf6291cd48a35edc189e5556116c3e0a

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Christoph can you please take a look at this?  I believe the changes for bug 1232901 are the cause.  Please see the pushlog in comment 3.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Jayme Mercado [:JMercado] from comment #4)
> Christoph can you please take a look at this?  I believe the changes for bug
> 1232901 are the cause.  Please see the pushlog in comment 3.

Hey Jayme, it's possible that Bug 1232901 caused this problem. Can you try to create a stacktrace and see why |_options.referrer| is null here [1]? When inspecting our codebase we haven't seen any codepaths where we don't pass the referrer. Once we have a callsite we should try to pass a referrer so that this code [1] works again correctly.

Also adding :aus, who helped me review the patch of Bug 1232901.

[1] https://hg.mozilla.org/integration/mozilla-inbound/rev/0f2a2b6bbf62#l1.42

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Please see the above comment.

Comment 7

[Aus Lacroix [:aus]]

I don't have any ideas off the top of my head as to why this would break suddenly unless the feature code itself in Gaia has changed. I'm no longer the maintainer for that, but if it's a blocking issue to address this I could potentially spend more time investigating.

Comment 8

[BMO Automation]

Firefox OS is not being worked on