1247676 - Style the noConvScreen and noAccountScreen like the in-content info pages.

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Richard Marti (:Paenglab)]

The noConvScreen and noAccountScreen could look a bit more modern like the in-content info- or error pages.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: ChatNewStyle.patch

Aleth, what do you think about this?

I haven't used the fixed colors of the in-content pages but system colors which are very similar to work also work on high contrast themes.

I also changed the noPreviewScreen for IB to look like TB Chat.

Comment 2

[aleth [:aleth]]

Attachment: Screen Shot

Note the bottom of the icon is cut off and the centering looks a bit wrong.

Comment 3

[aleth [:aleth]]

(In reply to Richard Marti (:Paenglab) from comment #1)
> Aleth, what do you think about this?

Looks great, thanks!

> I haven't used the fixed colors of the in-content pages but system colors
> which are very similar to work also work on high contrast themes.

That's up to you.

Will TB also use this for connection/cert errors?

Comment 4

[Richard Marti (:Paenglab)]

Attachment: ChatNewStyle.patch

I added a min-height to prevent the cut off. The centering should be fixed.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Other Screen Shot

Screenshot of a other screen.

Comment 6

[Richard Marti (:Paenglab)]

(In reply to aleth [:aleth] from comment #3)
> 
> Will TB also use this for connection/cert errors?

Do they use the toolkit pages?

Comment 7

[aleth [:aleth]]

(In reply to Richard Marti (:Paenglab) from comment #6)
> (In reply to aleth [:aleth] from comment #3)
> > 
> > Will TB also use this for connection/cert errors?
> 
> Do they use the toolkit pages?

I'm not sure what mail/ uses for that.

Comment 8

[aleth [:aleth]]

(In reply to Richard Marti (:Paenglab) from comment #5)
> Created attachment 8718525 [details]
> Other Screen Shot
> 
> Screenshot of a other screen.

The text in the button seems off-center on this screenshot (but on OS X when I ran it it looked fine).

Comment 9

[aleth [:aleth]]

There is one more instance in IB I can think of which could in principle use this new style:
https://dxr.mozilla.org/comm-central/source/im/content/viewlog.xul#123
This isn't an info page though, but an error page (different icon).

Comment 10

[aleth [:aleth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc804924ef72

Comment 11

[Richard Marti (:Paenglab)]

Attachment: ChatNewStyle.patch

I only added a rule for the .button-box and removed the padding in button like in in-content css to center the button text.

Comment 12

[aleth [:aleth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=840f0040fa5b

Comment 13

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/6e025138a9cf3f7a6e61dc8a9ce54b425b2e6993
Bug 1247676 - Style the placeholder-screen in in-content appearance. r=aleth

Comment 14

[aleth [:aleth]]

Does Fx 45 have the in-content error pages? i.e. should this be uplifted?

Comment 15

[Richard Marti (:Paenglab)]

Yes, i wanted only to wait for a Daily with this patch applied before asking approval.

Comment 16

[Richard Marti (:Paenglab)]

Comment on attachment 8718922 [details] [diff] [review]
ChatNewStyle.patch

[Approval Request Comment]
User impact if declined: no impact, but the new one looks better ;)
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 17

[Jorg K (CEST = GMT+2)]

Comment on attachment 8718922 [details] [diff] [review]
ChatNewStyle.patch

Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/65b564db348b

Comment 18

[Kent James (:rkent)]

Comment on attachment 8718922 [details] [diff] [review]
ChatNewStyle.patch

http://hg.mozilla.org/releases/comm-beta/rev/9e83eb98346f