Closed Bug 1247676 Opened 4 years ago Closed 4 years ago

Style the noConvScreen and noAccountScreen like the in-content info pages.

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set

Tracking

(thunderbird45 fixed, thunderbird46 fixed, thunderbird47 fixed)

RESOLVED FIXED
Thunderbird 47.0
Tracking Status
thunderbird45 --- fixed
thunderbird46 --- fixed
thunderbird47 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(3 files, 2 obsolete files)

The noConvScreen and noAccountScreen could look a bit more modern like the in-content info- or error pages.
Attached patch ChatNewStyle.patch (obsolete) — Splinter Review
Aleth, what do you think about this?

I haven't used the fixed colors of the in-content pages but system colors which are very similar to work also work on high contrast themes.

I also changed the noPreviewScreen for IB to look like TB Chat.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8718420 - Flags: review?(aleth)
Attached image Screen Shot
Note the bottom of the icon is cut off and the centering looks a bit wrong.
(In reply to Richard Marti (:Paenglab) from comment #1)
> Aleth, what do you think about this?

Looks great, thanks!

> I haven't used the fixed colors of the in-content pages but system colors
> which are very similar to work also work on high contrast themes.

That's up to you.

Will TB also use this for connection/cert errors?
Attached patch ChatNewStyle.patch (obsolete) — Splinter Review
I added a min-height to prevent the cut off. The centering should be fixed.
Attachment #8718420 - Attachment is obsolete: true
Attachment #8718420 - Flags: review?(aleth)
Attachment #8718524 - Flags: review?(aleth)
Attached image Other Screen Shot
Screenshot of a other screen.
(In reply to aleth [:aleth] from comment #3)
> 
> Will TB also use this for connection/cert errors?

Do they use the toolkit pages?
(In reply to Richard Marti (:Paenglab) from comment #6)
> (In reply to aleth [:aleth] from comment #3)
> > 
> > Will TB also use this for connection/cert errors?
> 
> Do they use the toolkit pages?

I'm not sure what mail/ uses for that.
Attachment #8718524 - Flags: review?(aleth) → review+
(In reply to Richard Marti (:Paenglab) from comment #5)
> Created attachment 8718525 [details]
> Other Screen Shot
> 
> Screenshot of a other screen.

The text in the button seems off-center on this screenshot (but on OS X when I ran it it looked fine).
There is one more instance in IB I can think of which could in principle use this new style:
https://dxr.mozilla.org/comm-central/source/im/content/viewlog.xul#123
This isn't an info page though, but an error page (different icon).
I only added a rule for the .button-box and removed the padding in button like in in-content css to center the button text.
Attachment #8718524 - Attachment is obsolete: true
Attachment #8718922 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/6e025138a9cf3f7a6e61dc8a9ce54b425b2e6993
Bug 1247676 - Style the placeholder-screen in in-content appearance. r=aleth
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
Does Fx 45 have the in-content error pages? i.e. should this be uplifted?
Yes, i wanted only to wait for a Daily with this patch applied before asking approval.
Comment on attachment 8718922 [details] [diff] [review]
ChatNewStyle.patch

[Approval Request Comment]
User impact if declined: no impact, but the new one looks better ;)
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8718922 - Flags: approval-comm-beta?
Attachment #8718922 - Flags: approval-comm-aurora?
Comment on attachment 8718922 [details] [diff] [review]
ChatNewStyle.patch

Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/65b564db348b
Attachment #8718922 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 8718922 [details] [diff] [review]
ChatNewStyle.patch

http://hg.mozilla.org/releases/comm-beta/rev/9e83eb98346f
Attachment #8718922 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.