Closed Bug 1247677 Opened 4 years ago Closed 4 years ago

APZ wheel scrolling doesn't respect all the prefs

Categories

(Core :: Panning and Zooming, defect)

47 Branch
All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox45 --- unaffected
firefox46 + fixed
firefox47 + fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Keywords: regression)

Attachments

(1 file)

So it turns out that on desktop, you can control the speeds of various smooth-scrolling animations by the general.smoothScroll.* prefs.

"Normal" mousewheel scrolling is controlled by general.smoothScroll.mouseWheel* prefs, which are respected by APZ.
"Page" mousewheel scrolling (if you change the wheel settings in the Windows control panel) is controlled by general.smoothScroll.page* prefs, which are *not* currently respected by APZ, which arni2033 pointed out to me in an email.

I assume that some mousewheels also support pixel-scrolling, which would be controlled by the general.smoothScroll.pixel* prefs, although I'm less sure about that. At any rate, we have a regression in behaviour with APZ because APZ supports page scrolling from mousewheel but doesn't respect the right prefs.

I'm working on the patch for page support, and I'll probably write a parallel one up for the pixel support.
Duplicate of this bug: 1234987
Comment on attachment 8718481 [details]
MozReview Request: Bug 1247677 - Add support for the general.smoothScroll.{pages,pixels} prefs in APZ. r?dvander

https://reviewboard.mozilla.org/r/34589/#review31269
Attachment #8718481 - Flags: review?(dvander) → review+
Compiler on linux is more smart than the windows one. New try push is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2ff0410da92&group_state=expanded, looking green so far.
There's a test failure in dom/events/test/test_bug607464.html, seems like pixel scrolling isn't supposed to be smooth even if the pref is set. I read bug 607464 and it seems like pixel scrolling didn't work well with smooth scrolling on some mac hardware. That might be fixed now but I don't know for sure, so I'll update my patch to match that.
https://hg.mozilla.org/mozilla-central/rev/558b65cbe70d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8718481 [details]
MozReview Request: Bug 1247677 - Add support for the general.smoothScroll.{pages,pixels} prefs in APZ. r?dvander

Approval Request Comment
[Feature/regressing bug #]: bug 1228028
[User impact if declined]: the default speed of page-scrolling with a mousewheel is slower than it used to be, and the prefs to control that speed don't work.
[Describe test coverage new/current, TreeHerder]: locally
[Risks and why]: low-risk, relatively small and contained change
[String/UUID change made/needed]: none
Attachment #8718481 - Flags: approval-mozilla-aurora?
Regression, tracking
Comment on attachment 8718481 [details]
MozReview Request: Bug 1247677 - Add support for the general.smoothScroll.{pages,pixels} prefs in APZ. r?dvander

Fix for recent apz scrolling regression, ok to uplift to aurora.
Attachment #8718481 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
has problems uplifting grafting 328687:558b65cbe70d "Bug 1247677 - Add support for the general.smoothScroll.{pages,pixels} prefs in APZ. r=dvander"
merging gfx/layers/apz/src/APZCTreeManager.cpp
merging gfx/layers/apz/src/AsyncPanZoomController.cpp
merging gfx/layers/apz/src/WheelScrollAnimation.cpp
merging gfx/thebes/gfxPrefs.h
warning: conflicts while merging gfx/layers/apz/src/WheelScrollAnimation.cpp! (edit, then use 'hg resolve --mark')
Flags: needinfo?(bugmail.mozilla)
Depends on: 1269068
You need to log in before you can comment on or make changes to this bug.