1247727 - [FlyWeb] Implement FlyWeb UI for Fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Justin D'Arcangelo [:justindarc]]

Since UI in Fennec is handled via native Android SDK, a "new tab" panel needs to be created for discovering and connecting to FlyWeb services in Firefox for Android.

Comment 1

[Justin D'Arcangelo [:justindarc]]

I already have an in-progress patch for this to land on "larch" project branch for FlyWeb. Assigning to myself.

Comment 2

[Richard Newman [:rnewman]]

I'm pretty sure we're not adding any new panels in Fennec; we're actively trying to consolidate ones we have, not add more.

Comment 3

[Justin D'Arcangelo [:justindarc]]

(In reply to Richard Newman [:rnewman] from comment #2)
> I'm pretty sure we're not adding any new panels in Fennec; we're actively
> trying to consolidate ones we have, not add more.

rnewman: This is not a permanent thing. Just some temporary UI for experimenting with FlyWeb on Fennec. Once we have a working implementation, we'll consult with UX on a final UI design.

Comment 4

[:Margaret Leibovic]

I was under the impression that this FlyWeb work was for demonstration purposes, not for landing something in the product.

If we're going to try to land something in the product, you should consult with our product manager (Barbara Bermes) about a plan for what we're going to include.

I understand that a lot of the platform work required for FlyWeb makes it difficult to implement as an add-on, but I have a strong suspicion we'd want the UI to live in an add-on, even if we land the platform hooks in gecko itself.

Comment 5

[Justin D'Arcangelo [:justindarc]]

(In reply to :Margaret Leibovic from comment #4)
> I was under the impression that this FlyWeb work was for demonstration
> purposes, not for landing something in the product.
> 
> If we're going to try to land something in the product, you should consult
> with our product manager (Barbara Bermes) about a plan for what we're going
> to include.
> 
> I understand that a lot of the platform work required for FlyWeb makes it
> difficult to implement as an add-on, but I have a strong suspicion we'd want
> the UI to live in an add-on, even if we land the platform hooks in gecko
> itself.

We are currently working out of a project branch, not M-C. This bug is simply to track progress on a patch for some temporary UI for experimenting with FlyWeb for the Fennec-to-Desktop use cases. Any UI that lands on this project branch will likely be discarded before the eventual merge to M-C.

Comment 6

[:Margaret Leibovic]

Okay, thanks for the clarification. This is just confusing for us because this bug is filed under the Firefox for Android product, and usually work that happens here targets landing in mozilla-central. This may not be the best place to track this work.

And I certainly want to review any changes to /mobile that are going to end up merging back to m-c.

Comment 7

[Justin D'Arcangelo [:justindarc]]

(In reply to :Margaret Leibovic from comment #6)
> Okay, thanks for the clarification. This is just confusing for us because
> this bug is filed under the Firefox for Android product, and usually work
> that happens here targets landing in mozilla-central. This may not be the
> best place to track this work.
> 
> And I certainly want to review any changes to /mobile that are going to end
> up merging back to m-c.

No problem. I naturally assumed it would be best to file this under "Firefox for Android", but perhaps I was wrong. I'd be open to any better suggestions you may have.

Also, we'll be sure to flag you for review when the time comes to merge to m-c. I'll also likely flag you for feedback as soon as I post the patch here for the "larch" branch so I can address any concerns in advance :-)

Comment 8

[Barbara Bermes [:barbara] - NI please!]

Thanks Justin for your understanding and feedback.

Feel free to track our roadmap (https://mozilla.aha.io/published/9e4032368f0ba842dbc2f121a8246b36?page=2) that outlines our plans and directions for Fennec, especially the consolidation of panels.

Comment 9

[Justin D'Arcangelo [:justindarc]]

Attachment: bug1247727.patch

Margaret: Since you said you were interested in looking at this patch, I've flagged you for feedback. I know you already said that the plan moving forward with Fennec involves reducing the number of home tab panels. However, for the sake of moving quickly to begin experimenting on the "larch" project branch, this patch adds a "FlyWeb" panel to list the nearby services. Before FlyWeb lands on m-c, the UI on both desktop and Android will be completely re-designed by UX (we are doing something similar on desktop by adding a toolbar icon with temporary UI).

Kannan: Here you go! You should be able to connect to FlyWeb services from Android with this :-D

Comment 10

[:Margaret Leibovic]

Comment on attachment 8721028 [details] [diff] [review]
bug1247727.patch

Review of attachment 8721028 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for flagging. My main concern is being involved early in any code that you're planning to land on mozilla-central. If this is throwaway code for a prototype, I'm less concerned about having a look at this.

I do want to make it really clear that there's about a 0% chance we're going to want to land a new home panel for fly web in the product itself, so I don't want to see you invest too much time in refining the code for this approach.

Comment 11

[Kannan Vijayan [:djvj]]

Comment on attachment 8721028 [details] [diff] [review]
bug1247727.patch

Review of attachment 8721028 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: mobile/android/chrome/content/browser.js
@@ +2086,5 @@
> +        break;
> +
> +      case "FlyWeb:ListServicesStop":
> +        console.log('**** FlyWeb:ListServicesStop ****');
> +        

Nit: whitespace on blank line.

@@ +2092,5 @@
> +        break;
> +
> +      case "FlyWeb:ConnectToService":
> +        console.log('**** FlyWeb:ConnectToService ****');
> +        

Nit: whitespace on blank line.

Comment 12

[Justin D'Arcangelo [:justindarc]]

https://hg.mozilla.org/projects/larch/rev/bd2d5822aae44644919a04e81f197b01f9a57694
Bug 1247727 - [FlyWeb] Implement FlyWeb UI for Fennec;r=djvj