1247743 - Expose non-pinning JS_Atomize[UC]String JSAPI functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Expose non-pinning JS_Atomize[UC]String JSAPI functions

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2b81b1a890d

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8718533 [details] [diff] [review]
Expose non-pinning JS_Atomize[UC]String JSAPI functions

Review of attachment 8718533 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me.

::: js/src/jsapi.h
@@ +4338,5 @@
>  extern JS_PUBLIC_API(JSString*)
>  JS_AtomizeAndPinJSString(JSContext* cx, JS::HandleString str);
>  
>  extern JS_PUBLIC_API(JSString*)
> +    JS_AtomizeStringN(JSContext* cx, const char* s, size_t length);

What's up with this starting whitespace? Please start the function name at the start of the line here and below.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Expose non-pinning JS_Atomize[UC]String JSAPI functions

Woops, fix whitespace.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/45e529de7f7a

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/45e529de7f7a