Open Bug 1247762 Opened 5 years ago Updated 3 years ago

Dump debug logs from GLContexts on destruction

Categories

(Core :: Canvas: WebGL, defect, P3)

defect

Tracking

()

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

(Keywords: feature, Whiteboard: [gfx-noted])

Attachments

(1 file)

Mesa seems to leak these messages so while we should fix mesa, printing them is probably more helpful.
Blocks: 1220658
Assignee: nobody → jmuizelaar
Attachment #8718624 - Flags: review?(jgilbert)
Comment on attachment 8718624 [details] [diff] [review]
Dump debug logs from GLContexts on destruction

Review of attachment 8718624 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +2359,5 @@
> +            GLsizei length;
> +
> +            GLuint numFound;
> +            do {
> +                numFound = fGetDebugMessageLog(1, maxMsgLen, &source, &type, &id, &severity, &length, &msgData[0]);

Please leave a comment that includes a link to this bug, to help explain why we're bothering with this. It seems silly otherwise.
Attachment #8718624 - Flags: review?(jgilbert) → review+
This is not fixing the leak...
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> This is not fixing the leak...

Can we patch Mesa? Would that be workable?
Thomas Daede in my office already contributes to Mesa, so I may ask him about this.
(In reply to Jeff Gilbert [:jgilbert] from comment #4)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> > This is not fixing the leak...
> 
> Can we patch Mesa? Would that be workable?
> Thomas Daede in my office already contributes to Mesa, so I may ask him
> about this.

We can but we need to find the leak which I've thus far failed to do. The alternative is to add an address-sanitizer supression.
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> (In reply to Jeff Gilbert [:jgilbert] from comment #4)
> > (In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> > > This is not fixing the leak...
> > 
> > Can we patch Mesa? Would that be workable?
> > Thomas Daede in my office already contributes to Mesa, so I may ask him
> > about this.
> 
> We can but we need to find the leak which I've thus far failed to do. The
> alternative is to add an address-sanitizer supression.

We should do whatever's easiest. We don't really care about the driver leak per se, only that we can run tests against the driver.
Keywords: feature
Whiteboard: [gfx-noted]
You need to log in before you can comment on or make changes to this bug.