Closed
Bug 1247780
Opened 10 years ago
Closed 10 years ago
Refactor Smart System to use modern L10n API
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
It's going to be mostly a port of changes that landed in system in bug 1244629.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8718618 [details] [review]
[gaia] zbraniecki:1247780-refactor-remaining-l10n-in-smart-system > mozilla-b2g:master
And this is the second part of System refactor moving away from mozL10n.get.
Attachment #8718618 -
Flags: review?(rexboy)
|
|
Assignee | |
Comment 3•10 years ago
|
||
:rexboy, can you review this for me, pls? :)
Flags: needinfo?(rexboy)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8718618 [details] [review]
[gaia] zbraniecki:1247780-refactor-remaining-l10n-in-smart-system > mozilla-b2g:master
Sorry for the late review.
Overall it looks good, but I found some issues in the patch.
Please see my comments on Github.
Flags: needinfo?(rexboy)
Attachment #8718618 -
Flags: review?(rexboy)
|
|
Assignee | |
Comment 5•10 years ago
|
||
:rexboy, I responded to your comments in the PR. Can you decide on what's the next step here?
Flags: needinfo?(rexboy)
|
|
||
Comment 6•10 years ago
|
||
Sorry, I just didn't see the notification.
I've replied on Github, you can just make change and send a review to me again.
Thanks a lot!
Flags: needinfo?(rexboy)
|
|
Assignee | |
Comment 7•10 years ago
|
||
Comment on attachment 8718618 [details] [review]
[gaia] zbraniecki:1247780-refactor-remaining-l10n-in-smart-system > mozilla-b2g:master
Cool! Fixed the code and filed bug 1252579 to deal with the <smart-button> design.
Attachment #8718618 -
Flags: review?(rexboy)
|
|
||
Comment 8•10 years ago
|
||
Comment on attachment 8718618 [details] [review]
[gaia] zbraniecki:1247780-refactor-remaining-l10n-in-smart-system > mozilla-b2g:master
Looks good to me! Thank you.
Attachment #8718618 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•