Refactor Smart System to use modern L10n API

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::System
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
It's going to be mostly a port of changes that landed in system in bug 1244629.
Created attachment 8718618 [details] [review]
[gaia] zbraniecki:1247780-refactor-remaining-l10n-in-smart-system > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Assignee: nobody → gandalf
Blocks: 1247710
(Assignee)

Comment 2

2 years ago
Comment on attachment 8718618 [details] [review]
[gaia] zbraniecki:1247780-refactor-remaining-l10n-in-smart-system > mozilla-b2g:master

And this is the second part of System refactor moving away from mozL10n.get.
Attachment #8718618 - Flags: review?(rexboy)
(Assignee)

Comment 3

2 years ago
:rexboy, can you review this for me, pls? :)
Flags: needinfo?(rexboy)
Comment on attachment 8718618 [details] [review]
[gaia] zbraniecki:1247780-refactor-remaining-l10n-in-smart-system > mozilla-b2g:master

Sorry for the late review. 
Overall it looks good, but I found some issues in the patch.
Please see my comments on Github.
Flags: needinfo?(rexboy)
Attachment #8718618 - Flags: review?(rexboy)
(Assignee)

Comment 5

2 years ago
:rexboy, I responded to your comments in the PR. Can you decide on what's the next step here?
Flags: needinfo?(rexboy)
Sorry, I just didn't see the notification.
I've replied on Github, you can just make change and send a review to me again.
Thanks a lot!
Flags: needinfo?(rexboy)
(Assignee)

Comment 7

2 years ago
Comment on attachment 8718618 [details] [review]
[gaia] zbraniecki:1247780-refactor-remaining-l10n-in-smart-system > mozilla-b2g:master

Cool! Fixed the code and filed bug 1252579 to deal with the <smart-button> design.
Attachment #8718618 - Flags: review?(rexboy)
Comment on attachment 8718618 [details] [review]
[gaia] zbraniecki:1247780-refactor-remaining-l10n-in-smart-system > mozilla-b2g:master

Looks good to me! Thank you.
Attachment #8718618 - Flags: review?(rexboy) → review+
(Assignee)

Comment 9

2 years ago
Thanks!

Commit: https://github.com/mozilla-b2g/gaia/commit/d5f985331fd4f5bca6d55c03966cbe11379c2c0b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.