1247782 - Remove GeckoApp.createHealthRecorder & usages

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It appears we missed them when we implemented bug 1183320.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1247782 - Remove GeckoApp.createHealthRecorder & related code. r=rnewman

It seems we missed this when we implemented bug 1183320.

There was a FENNEC_WAS_KILLED histogram that used the SessionInformation - this
changeset maintains this functionality by pulling the access out of
SessionInformation and directly into GeckoApp, removing the SessionInformation
class.

Review commit: https://reviewboard.mozilla.org/r/34639/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34639/

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

fwiw, I didn't check that the FENNEC_WAS_KILLED histogram is still correctly set up after FHR was removed (and this patch was removed, for that matter).

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I initially removed these parts in bug 1183320, but Richard asked that we keep them so session tracking for "core" ping had a roadmap/breadcrumbs that could be followed from the way FHR tracked session time.

Comment 4

[Richard Newman [:rnewman]]

Correct.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I added the session recording for the core ping so we can delete this now.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.