Closed
Bug 1247810
Opened 8 years ago
Closed 8 years ago
GL_ALIASED_POINT_SIZE_RANGE isn't valid in Core Profiles
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(1 file)
1.21 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
LOCAL_GL_ALIASED_POINT_SIZE_RANGE is valid in ES3 but not desktop GL Core profiles. It's not real clear what to use instead, but GL_POINT_SIZE_RANGE seems likely.
Attachment #8718642 -
Flags: review?(jmuizelaar)
Comment 1•8 years ago
|
||
Comment on attachment 8718642 [details] [diff] [review] 0001-Redirect-the-enum-query-on-Core-profiles.patch Review of attachment 8718642 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGLContextState.cpp @@ +572,5 @@ > + GLenum driverPName = pname; > + if (gl->IsCoreProfile() && > + driverPName == LOCAL_GL_ALIASED_POINT_SIZE_RANGE) > + { > + driverPName = LOCAL_GL_POINT_SIZE_RANGE; Adding "GL_ALIASED_POINT_SIZE_RANGE isn't valid in Core Profiles" as a comment wouldn't hurt.
Attachment #8718642 -
Flags: review?(jmuizelaar) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f054c2480618
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•