Closed Bug 1247838 Opened 5 years ago Closed 5 years ago
git mozreview doesn't work from a subdirectory
58 bytes, text/x-review-board-request
This is a regression from bug 1246998
This patch essentially works: https://reviewboard.mozilla.org/r/34729/ But... it looks like cinnabar doesn't work properly in that case (this scares the hell out of me), so let's not fix this for now...
(In reply to Mike Hommey [:glandium] from comment #1) > This patch essentially works: > https://reviewboard.mozilla.org/r/34729/ > > But... it looks like cinnabar doesn't work properly in that case (this > scares the hell out of me) The good news is that it's not an issue with git push, presumably because git-remote-hg is invoked by git in a different way than git-cinnabar. Haven't figured out what makes the difference is yet.
Bug 1246998 broke it, and the push code in cinnabar assumes it's running from the toplevel directory, which is a fine assumption in the git-remote-hg helper, but not in the git cinnabar command. Until cinnabar itself is fixed, work around it. While here, add a test case for worktrees. Review commit: https://reviewboard.mozilla.org/r/34735/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34735/
Attachment #8718756 - Flags: review?(gps)
Comment on attachment 8718756 [details] MozReview Request: Bug 1247838 - Fix running git mozreview from a subdirectory. r=gps https://reviewboard.mozilla.org/r/34735/#review31687
Attachment #8718756 - Flags: review?(gps) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.