1247865 - @font-face + table + :before/:after causes "ASSERTION: aElement should be the element and not the pseudo-element: 'pseudoType == nsCSSPseudoElements::ePseudo_NotPseudoElement || ...", e.g. at hellocasa.fr

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit https://hellocasa.fr/ in a debug build.

ACTUAL RESULTS:
Several instances of this assertion during pageload:
{
###!!! ASSERTION: aElement should be the element and not the pseudo-element: 'pseudoType == nsCSSPseudoElements::ePseudo_NotPseudoElement || !elementForAnimation->GetPrimaryFrame() || elementForAnimation->GetPrimaryFrame()->StyleContext()-> GetPseudoType() == nsCSSPseudoElements::ePseudo_NotPseudoElement', file layout/style/nsStyleSet.cpp, line 1722
}

This assertion was added here for bug 996796, FWIW:
http://hg.mozilla.org/mozilla-central/diff/7ee0ebcf0602/layout/style/nsStyleSet.cpp#l1.48

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Here's a reduced testcase that still triggers the assertion for me.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is just a bug in the assertion expression; it needs to use nsLayoutUtils::GetStyleFrame to fix up table outer frames.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: MozReview Request: Bug 1247865 - Add crashtest for assertion. r?birtles

I confirmed locally that, without the following patch, the crashtest
harness does detect the single assertion.

Review commit: https://reviewboard.mozilla.org/r/34879/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34879/

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: MozReview Request: Bug 1247865 - Fix assertion to handle restyling of a table::after. r?birtles

I confirmed locally that this patch does fix the assertion in the
crashtest.

Review commit: https://reviewboard.mozilla.org/r/34881/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34881/

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8719087 [details]
MozReview Request: Bug 1247865 - Add crashtest for assertion.  r?birtles

https://reviewboard.mozilla.org/r/34879/#review31489

Comment 6

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8719088 [details]
MozReview Request: Bug 1247865 - Fix assertion to handle restyling of a table::after.  r?birtles

https://reviewboard.mozilla.org/r/34881/#review31491

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0b93057bf480eea8e6d425a82f2ef097d0745e30
Bug 1247865 - Add crashtest for assertion.  r=birtles

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8db1845736b05a1d9714df55ac9ed76847d8899
Bug 1247865 - Fix assertion to handle restyling of a table::after.  r=birtles

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0b93057bf480
https://hg.mozilla.org/mozilla-central/rev/d8db1845736b