[Static Analysis][Resource leak] In function ensureDatabaseIsNotLocked

RESOLVED WORKSFORME

Status

()

Firefox for Android
Data Providers
RESOLVED WORKSFORME
2 years ago
2 years ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 2 bugs, {coverity})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: CID 119594 )

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The Static Analysis tool Coverity added a memory leak occurs on variable db, we should close it before exiting it's context.
(Assignee)

Comment 1

2 years ago
Created attachment 8718763 [details]
MozReview Request: Bug 1247878 - close db when exiting ensureDatabaseIsNotLocked.  r?mfinkle

Review commit: https://reviewboard.mozilla.org/r/34743/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34743/
Attachment #8718763 - Flags: review?(mark.finkle)
Comment on attachment 8718763 [details]
MozReview Request: Bug 1247878 - close db when exiting ensureDatabaseIsNotLocked.  r?mfinkle

Passing to Mike. He's a better reviewer for this.
Attachment #8718763 - Flags: review?(mark.finkle) → review?(michael.l.comella)
Comment on attachment 8718763 [details]
MozReview Request: Bug 1247878 - close db when exiting ensureDatabaseIsNotLocked.  r?mfinkle

https://reviewboard.mozilla.org/r/34743/#review31793

This was discussed and decided to be intentional in bug 1246839 (see https://bugzilla.mozilla.org/show_bug.cgi?id=1246839#c13). I updated the issue in Coverity – are you able to see that?
Attachment #8718763 - Flags: review?(michael.l.comella)
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
Blocks: 1248773
(Assignee)

Comment 4

2 years ago
Thanks Michael for letting me know. Yes i haev access to Coverity so i can see it.
You need to log in before you can comment on or make changes to this bug.