Closed Bug 1247878 Opened 4 years ago Closed 4 years ago

[Static Analysis][Resource leak] In function ensureDatabaseIsNotLocked

Categories

(Firefox for Android :: Data Providers, defect)

defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: andi, Assigned: andi)

References

(Blocks 2 open bugs)

Details

(Keywords: coverity, Whiteboard: CID 119594 )

Attachments

(1 file)

The Static Analysis tool Coverity added a memory leak occurs on variable db, we should close it before exiting it's context.
Comment on attachment 8718763 [details]
MozReview Request: Bug 1247878 - close db when exiting ensureDatabaseIsNotLocked.  r?mfinkle

Passing to Mike. He's a better reviewer for this.
Attachment #8718763 - Flags: review?(mark.finkle) → review?(michael.l.comella)
Comment on attachment 8718763 [details]
MozReview Request: Bug 1247878 - close db when exiting ensureDatabaseIsNotLocked.  r?mfinkle

https://reviewboard.mozilla.org/r/34743/#review31793

This was discussed and decided to be intentional in bug 1246839 (see https://bugzilla.mozilla.org/show_bug.cgi?id=1246839#c13). I updated the issue in Coverity – are you able to see that?
Attachment #8718763 - Flags: review?(michael.l.comella)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
Thanks Michael for letting me know. Yes i haev access to Coverity so i can see it.
You need to log in before you can comment on or make changes to this bug.