1247922 - [Static Analysis][Resource leak] In function GetManifestContents

Status: RESOLVED DUPLICATE of bug 1247217

(Toolkit :: Application Update, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that in the following context if if is evaluated to true mbuf leaks:

>>    const size_t count = mmin(SSIZE_MAX, r);
>>    size_t c = fread(rb, 1, count, mfile);
>>    if (c != count) {
>>      LOG(("GetManifestContents: error reading manifest file: " LOG_S, manifest));
>>      return nullptr;
    }

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1247922 - free mbuf even if something wrong happened during fread. r?netzen

Review commit: https://reviewboard.mozilla.org/r/34755/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34755/