1248022 - ConsoleEvent.styles can be a sequence of nullable strings.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: console1.patch

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8718947 [details] [diff] [review]
console1.patch

>+              if (!aStyles.AppendElement(EmptyString(), fallible)) {

You mean NullString(), right?  Please add a test, since apparently we have no test coverage for this....

>+          if (!aStyles.AppendElement(string, fallible)) {

So this is going to make a copy out of the autostring.  I guess in practice this is not a big deal, and all our APIs around this suck a bit, sadly...

r=me with the NullString() fixed.

Comment 2

[Andrea Marchesini [:baku]]

> You mean NullString(), right?  Please add a test, since apparently we have
> no test coverage for this....

We have some tests here: shared/webconsole/test/test_console_styling.html

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db0f2e9327af

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/db0f2e9327af