1248034 - Empty state for bookmarks panel

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Bookmarks Panel Empty State

We currently always show the DefaultSuggestedSites in the user's bookmarks. This bug is about removing those.

This also means we need an empty state for the Bookmarks panel, since it will empty for a new clean install. This bug has an attachment with a first iteration of that screen.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Needinfo on :tecgirl to confirm that the empty state is good to go.

Comment 2

[Robin Andersen [:tecgirl]]

Attachment: BookmarksEmptyPanel.zip

Comment 3

[Bryan Munar (:bkmunar)]

Attachment: PR - for strings

Comment 4

[Robin Andersen [:tecgirl]]

Comment on attachment 8721462 [details] [review]
PR - for strings

I'm still seeing the Alexa Top 5 as default bookmarks, and unable to delete them. I know those are separate bugs, but I'm unable to review the empty state if I can't make it empty.

Comment 5

[Richard Newman [:rnewman]]

I'll add a trivial commit that we can back out before landing bookmarks sync.

Comment 6

[Richard Newman [:rnewman]]

Done. Ready for you.

Comment 7

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 8

[Richard Newman [:rnewman]]

Comment on attachment 8722672 [details] [review]
PR

Clean up your commit messages!

Comment 9

[Bryan Munar (:bkmunar)]

(In reply to Richard Newman [:rnewman] from comment #8)
> Comment on attachment 8722672 [details] [review]
> PR
> 
> Clean up your commit messages!

i think i already did!

Comment 10

[Stephan Leroux [:sleroux]]

Comment on attachment 8722672 [details] [review]
PR

Looks good just a couple of questions in the PR.

Comment 11

[Stephan Leroux [:sleroux]]

Comment on attachment 8722672 [details] [review]
PR

Solid stuff. Minor nits but good to go.