1248035 - Clean port of Sony devices based on restructured device repos

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Adam Farden [:adfad666]]

In cooperation with Sony we completely restructured the device repos. We now have three level dependency [device -> platform -> common] which consolidates a ton of duplicated code from across five platforms.

androidboot.hardware in the kernel cmdline is now the device instead of the platform, which means better compatibility with AOSP. However this is a breaking change; old boot images will NOT boot with new system images (and vice versa).

We are informed that the camera blobs have been calibrated. This means on the next blobzip update we should finally have a camera that takes actual pictures!

I have chosen to do a clean B2G port because the changes are simply too dramatic to even try to do a git merge. Most of what we changed is now in a completely different repo.

Comment 1

[Adam Farden [:adfad666]]

Attachment: Test Manifest

If anyone wishes to test before I create that actual PRs this manifest should work.

Comment 2

[:gerard-majax]

Thanks, I'll give it a test asap

Comment 3

[Adam Farden [:adfad666]]

Attachment: Kernel PR

Comment 4

[Adam Farden [:adfad666]]

Attachment: Flamingo PR

Comment 5

[Adam Farden [:adfad666]]

Attachment: Eagle PR

Comment 6

[Adam Farden [:adfad666]]

Attachment: Seagull PR

Comment 7

[Adam Farden [:adfad666]]

Attachment: Yukon PR

Comment 8

[Adam Farden [:adfad666]]

Attachment: Sirius PR

Comment 9

[Adam Farden [:adfad666]]

Attachment: Scorpion PR

This depends on a fork of https://github.com/sonyxperiadev/device-sony-scorpion_windy

Comment 10

[Adam Farden [:adfad666]]

Attachment: Aries PR

Comment 11

[Adam Farden [:adfad666]]

Attachment: Leo PR

Comment 12

[Adam Farden [:adfad666]]

Attachment: Shinano PR

Comment 13

[Adam Farden [:adfad666]]

Attachment: Amami PR

Comment 14

[Adam Farden [:adfad666]]

Attachment: Honami PR

Comment 15

[Adam Farden [:adfad666]]

Attachment: Rhine PR

Comment 16

[Adam Farden [:adfad666]]

We need forks of:

https://github.com/sonyxperiadev/device-sony-common
https://github.com/sonyxperiadev/device-sony-scorpion_windy

Comment 17

[:gerard-majax]

(In reply to Adam Farden [:adfad666] from comment #16)
> We need forks of:
> 
> https://github.com/sonyxperiadev/device-sony-common
> https://github.com/sonyxperiadev/device-sony-scorpion_windy

Done:
https://github.com/mozilla-b2g/device-sony-common
https://github.com/mozilla-b2g/device-sony-scorpion_windy

Comment 18

[Adam Farden [:adfad666]]

Attachment: Scorpion Windy PR

Comment 19

[Adam Farden [:adfad666]]

Attachment: Common PR

Comment 20

[Adam Farden [:adfad666]]

Attachment: macaddrsetup PR

Comment 21

[Adam Farden [:adfad666]]

Attachment: timekeep PR

Comment 22

[:gerard-majax]

I will test those on the devices I have: Z3 ; Z3c ; Z1c ; M2

Comment 23

[:gerard-majax]

I guess we will also need patches for:
 - xml repo manifest changes
 - b2g repo changes (adding scorpion windy)

Comment 24

[:gerard-majax]

it boots but I have no wifi working (seems the interface does not even gets up when requested by wpa_supplicant) and I cannot connect data.

Comment 26

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #24)
> it boots but I have no wifi working (seems the interface does not even gets
> up when requested by wpa_supplicant) and I cannot connect data.

With updated kernel PR and new repo vendor-qcom-opensource-dataservices I have data and wifi again.

Comment 27

[:gerard-majax]

Comment on attachment 8721478 [details] [review]
Aries PR

There are broken parts in this repo that references Sirius at least

Comment 28

[:gerard-majax]

If it works well enough on Z3, Z3 Tablet, Z1c and M2 I'll land all those.

Comment 29

[:gerard-majax]

Attachment: Manifest update

Comment 30

[Adam Farden [:adfad666]]

Comment on attachment 8721802 [details]
Manifest update

You also need the scorpion_windy repo

Comment 31

[Adam Farden [:adfad666]]

Comment on attachment 8721478 [details] [review]
Aries PR

Commits fixed and PR updated

Comment 32

[:gerard-majax]

GSM works but no data signal seems to come on Z1c

Comment 33

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #32)
> GSM works but no data signal seems to come on Z1c

02-22 14:25:10.196   337   760 I Gecko   : RIL Worker: [0] data registration state: 2,,,,0,20,,,,,
02-22 14:25:10.204   337   760 I Gecko   : RIL Worker: [0] voice registration state: 2,,,0,,,,0,,,,,,0,
02-22 14:25:10.554   337   760 I Gecko   : RIL Worker: [0] data registration state: 2,,,,0,20,,,,,
02-22 14:25:10.558   337   760 I Gecko   : RIL Worker: [0] voice registration state: 1,2f46,0090d9c4,3,,,,0,,,,,,0,1c9
02-22 14:25:10.578   337   760 I Gecko   : RIL Worker: [0] voice registration state: 1,2f46,0090d9c4,3,,,,0,,,,,,0,1c9
02-22 14:25:10.581   337   760 I Gecko   : RIL Worker: [0] data registration state: 2,,,,0,20,,,,,
02-22 14:25:11.512   337   760 I Gecko   : RIL Worker: [0] voice registration state: 1,2f46,0090d9c4,3,,,,0,,,,,,0,1c9
02-22 14:25:11.521   337   760 I Gecko   : RIL Worker: [0] data registration state: 2,,,,0,20,,,,,
02-22 14:25:12.639   337   760 I Gecko   : RIL Worker: [0] voice registration state: 1,2f46,0090d9c4,3,,,,0,,,,,,0,1c9
02-22 14:25:12.660   337   760 I Gecko   : RIL Worker: [0] data registration state: 2,,,,0,20,,,,,
02-22 14:25:12.945   337   760 I Gecko   : RIL Worker: [0] data registration state: 2,,,,0,20,,,,,
02-22 14:25:12.952   337   760 I Gecko   : RIL Worker: [0] voice registration state: 1,2f46,0090d9c4,3,,,,0,,,,,,0,1c9
02-22 14:25:13.608   337   760 I Gecko   : RIL Worker: [0] voice registration state: 1,2f46,0090d9c4,3,,,,0,,,,,,0,1c9
02-22 14:25:13.609   337   760 I Gecko   : RIL Worker: [0] data registration state: 2,,,,0,20,,,,,
02-22 14:25:14.386   337   760 I Gecko   : RIL Worker: [0] data registration state: 2,,,,0,20,,,,,
02-22 14:25:14.389   337   760 I Gecko   : RIL Worker: [0] voice registration state: 1,2f46,0090d9c4,3,,,,0,,,,,,0,1c9
02-22 14:25:21.247   337   760 I Gecko   : RIL Worker: [0] voice registration state: 1,2f46,0090d9c4,3,,,,0,,,,,,0,1c9
02-22 14:25:21.275   337   760 I Gecko   : RIL Worker: [0] data registration state: 2,,,,0,20,,,,,

Comment 34

[:gerard-majax]

Scorpion kernel lacks FANOTIFY and SECCOMP

Comment 35

[:gerard-majax]

Bluetooth was broken because |bluetooth.default| package was missing from PRODUCT_PACKAGES

Comment 36

[:gerard-majax]

Let's find why NFC regressed. When enabling it we get:
> 02-22 17:26:09.790: D/(5408): phNxpLog_InitializeLogLevel: global =1, Fwdnld =1, extns =1,                 hal =1, tml =1, ncir =1,                 ncix =1
> 02-22 17:26:09.790: E/NxpTml(5408): _i2c_open() Failed: retval ffffffff
> 02-22 17:26:09.790: E/NxpHal(5408): phTmlNfc_Init Failed

Comment 37

[:gerard-majax]

Per private discussion, NFC was broken because of missing symlink with /dev entries

Comment 38

[Adam Farden [:adfad666]]

GSM slipped through me tests because it is a Rhine platform specific issue. We can't solve it; the issue lies in the blobzip. I confirmed GSM is not working on AOSP too. Sony has been informed.

(We could of course use an older blobzip)

Yukon and Shinano (and Kitakami if/when we are able to support this platform) all have working GSM on B2G.

Comment 39

[Adam Farden [:adfad666]]

Attachment: Manifest PR

Comment 40

[:gerard-majax]

https://github.com/mozilla-b2g/timekeep/commit/460869402e019b122c4e5ffce19bfbbad026c0fe
https://github.com/mozilla-b2g/macaddrsetup/commit/1e31df0400fda7d80151bd4c5441027cd49749f8
https://github.com/mozilla-b2g/device-sony-common/commit/8956834338d21b18718149575a6c0a1466446cda
https://github.com/mozilla-b2g/codeaurora_kernel_msm/commit/36e3286b400566d0cfe9ea9f54ca76039910bf92
https://github.com/mozilla-b2g/device-sony-rhine/commit/f8fc588e9bb7c4dc89e4dd0625dcc363ad042edb
https://github.com/mozilla-b2g/device-sony-shinano/commit/0d4a0909139c3c50075daa4a2300744b3921301d
https://github.com/mozilla-b2g/device-sony-yukon/commit/ddbb9c51a1ef0415dd91901cf00e5f821f9165b4
https://github.com/mozilla-b2g/device-sony-scorpion_windy/commit/03bf71ec1b0a934e36507e10eb80bc5869f7c72b
https://github.com/mozilla-b2g/device-sony-leo/commit/7fa58489a5ac3977d7609271b67f12f7609b2e01
https://github.com/mozilla-b2g/device-sony-aries/commit/27a90ca4e11e7954fd395fc0b62316c863fcb323
https://github.com/mozilla-b2g/device-sony-scorpion/commit/7a511ecb29bd873156d7908ecc56d01e13512485
https://github.com/mozilla-b2g/device-sony-sirius/commit/763c7408f3132e7558d1f42a75ca212d59634259
https://github.com/mozilla-b2g/device-sony-seagull/commit/7e4049d36d071430741b0d7ccfc003b3a5c22272
https://github.com/mozilla-b2g/device-sony-eagle/commit/c32653915fc96c1fbf75bffb95ad9485fa005c6f
https://github.com/mozilla-b2g/device-sony-flamingo/commit/ad9110649ec467518900932f648e45ce36effaeb
https://github.com/mozilla-b2g/device-sony-honami/commit/e2496d1b4de848042726d23eb3164c2281c2d526
https://github.com/mozilla-b2g/device-sony-amami/commit/6fa4f527b07a997c650d2b2e586839bdd29f9820

Comment 41

[:gerard-majax]

https://github.com/mozilla-b2g/b2g-manifest/commit/7fafd8003c6157e23f1145f7c58c4af0ebf699aa

Comment 42

[hwine]

NOTE: this commit breaks all b2g builds on build infra (bug 1250588). They will remain broken until the new repos are mirrored to git.mozilla.org

Please see https://wiki.mozilla.org/ReleaseEngineering/How_To/Request_a_New_Repository#Requester.27s_Actions: for details on what needs to be filed, and it should block this bug.

Comment 43

[:gerard-majax]

(In reply to Hal Wine [:hwine] (use NI) from comment #42)
> NOTE: this commit breaks all b2g builds on build infra (bug 1250588). They
> will remain broken until the new repos are mirrored to git.mozilla.org
> 
> Please see
> https://wiki.mozilla.org/ReleaseEngineering/How_To/
> Request_a_New_Repository#Requester.27s_Actions: for details on what needs to
> be filed, and it should block this bug.

Thanks, sorry for the noise, done as bug 1250864