1248043 - Approving smallish patch requires too many clicks

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect)

Description

[Jim Mathies [:jimm]]

It would be great if approving a patch could be accomplished from the page where I'm viewing the diff, without having to click through all the options and dialogs associated with r+ing a patch. Currently approval requires three clicks of the mouse -

- "finish review..." up top of the screen (hard to find and a bit ambiguous)
- check the "ship it" checkbox over on the left side of the screen
- click the publish button down at the bottom-right hand side of the screen

This is a rather annoying process to go through. A simple "Ship it" button in the diff view for single diff patches would be great.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Note that at least two times in the last three days I missed the second step of those, because of all the other steps I had to do... and then people were very confused at having no comments and the review request cancelled and trying to figure out what I meant.

Comment 2

[Gregory Szorc [:gps]]

We used to have a single "Ship It" button that would publish the review with a ship it. However, we removed it because people were clicking it and complaining that they didn't intend to grant r+. See bug 1195860 for what changed it.

Regarding the "Finish Review" dialog become a usability nightmare, there are several bugs on that and things are actively being worked on.

Comment 3

[(not currently active) Ted Mielczarek]

This has been bothering me a lot lately too. Chromium's Rietveld has this down to two clicks (and maybe I'm missing something): "Publish+Mail Comments", "Quick LGTM". There's also a keyboard shortcut for the first one (m).

Comment 5

[Mark Côté [:mcote]]

This will probably be fixed at the same time as bug 1207127.

Comment 6

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.