1248047 - Make key event handling more efficient

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Make GeckoInputConnection.sendKeyEvent more efficient (v1)

Right now, sendKeyEvent does a round trip from the IC thread to the UI
thread back to the IC thread. This patch makes it stay on the IC thread.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Simplify GeckoInputConnection.processKey (v1)

Right now, processKey uses a IC-thread proxy in order to handle key events on
the UI thread. This patch makes it post the key event to the IC thread and
avoid the proxy entirely. That also lets us get rid of a lot of code.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Switch back to UI thread when using physical keyboards (v1)

When using physical keyboards, we get key events on the UI thread. To
improve performance, and to support key listeners better, we should
switch the IC thread to the UI thread in that case.

Comment 4

[Eugen Sawin [:esawin]]

Comment on attachment 8719000 [details] [diff] [review]
Simplify GeckoInputConnection.processKey (v1)

Review of attachment 8719000 [details] [diff] [review]:
-----------------------------------------------------------------

Nice code reductions.

Comment 5

[Eugen Sawin [:esawin]]

Comment on attachment 8719001 [details] [diff] [review]
Switch back to UI thread when using physical keyboards (v1)

Review of attachment 8719001 [details] [diff] [review]:
-----------------------------------------------------------------

Do we handle the case where a hardware keyboard is present, but software keyboard is used for input correctly?

::: mobile/android/base/java/org/mozilla/gecko/GeckoEditable.java
@@ +761,1 @@
>          }

The two if-statements can be combined, identical return value.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Eugen Sawin [:esawin] from comment #5)
> Comment on attachment 8719001 [details] [diff] [review]
> Switch back to UI thread when using physical keyboards (v1)
> 
> Review of attachment 8719001 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Do we handle the case where a hardware keyboard is present, but software
> keyboard is used for input correctly?

Yep, soft keyboards should work just fine.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ea261ff82d3
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d5c8266acb1
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb08ccbe74a3

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0ea261ff82d3
https://hg.mozilla.org/mozilla-central/rev/3d5c8266acb1
https://hg.mozilla.org/mozilla-central/rev/cb08ccbe74a3