Errors building FaviconFetcher.swift

RESOLVED INVALID

Status

()

Firefox for iOS
Build & Test
RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Created attachment 8719041 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1530

Assuming this is from recently upgrading Alamofire?

/Users/brian/mozilla/ios/Utils/FaviconFetcher.swift:88:38: Downcast from 'NSError?' to 'NSError' only unwraps optionals; did you mean to use '!'?
(Assignee)

Comment 1

2 years ago
Created attachment 8719044 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1531
Attachment #8719041 - Attachment is obsolete: true
Attachment #8719044 - Flags: review?(etoop)
Comment on attachment 8719044 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1531

I have encountered this error before. What you need to do is do a full clean before building (cmd alt shift k) in order to force the linking against the alamofire dylib. For some reason it remains linked to an old version unless you do.
Attachment #8719044 - Flags: review?(etoop) → review-
(Assignee)

Comment 3

2 years ago
Ah, thanks for the tip -- I had only tried ⌘⇧K. I'll go ahead and close out bug 1248063 too since it's likely the same issue.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.