Replace preprocessor -I with CONFIGURE_SUBST_FILES in mobile/android/base/Makefile.in

RESOLVED FIXED in Firefox 46

Status

()

Core
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

unspecified
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed, firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug 1235109 landed and broke Adjust token processing for Fennec.
(Assignee)

Updated

2 years ago
Summary: Replace preprocessor -I to use CONFIGURE_SUBST_FILES in mobile/android/base/Makefile.in → Replace preprocessor -I with CONFIGURE_SUBST_FILES in mobile/android/base/Makefile.in
(Assignee)

Comment 1

2 years ago
Created attachment 8719093 [details]
MozReview Request: Bug 1248092 - Replace preprocessor -I with CONFIGURE_SUBST_FILES. r?glandium

Review commit: https://reviewboard.mozilla.org/r/34885/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34885/
Attachment #8719093 - Flags: review?(mh+mozilla)
Comment on attachment 8719093 [details]
MozReview Request: Bug 1248092 - Replace preprocessor -I with CONFIGURE_SUBST_FILES. r?glandium

https://reviewboard.mozilla.org/r/34885/#review31581
Attachment #8719093 - Flags: review?(mh+mozilla) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/05f8a1a4c09f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8719093 [details]
MozReview Request: Bug 1248092 - Replace preprocessor -I with CONFIGURE_SUBST_FILES. r?glandium

Approval Request Comment
[Feature/regressing bug #]: bug 1235109
[User impact if declined]: 46.0 beta builds will fail to compile
[Describe test coverage new/current, TreeHerder]: Both present in nightly
[Risks and why]: None known, nalexander is the expert
[String/UUID change made/needed]: None

Bug 1235109 removes build system support for a type of preprocessing in 46, but the mobile change to stop using that is only in 47. We need to uplift this patch to avoid compile failures.
Attachment #8719093 - Flags: approval-mozilla-aurora?
status-firefox46: --- → affected
Comment on attachment 8719093 [details]
MozReview Request: Bug 1248092 - Replace preprocessor -I with CONFIGURE_SUBST_FILES. r?glandium

Taking it to make sure that 46 is fixed.
Attachment #8719093 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/b7770ba5c620
Target Milestone: mozilla47 → mozilla46
status-firefox46: affected → fixed
You need to log in before you can comment on or make changes to this bug.