1248092 - Replace preprocessor -I with CONFIGURE_SUBST_FILES in mobile/android/base/Makefile.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

Bug 1235109 landed and broke Adjust token processing for Fennec.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1248092 - Replace preprocessor -I with CONFIGURE_SUBST_FILES. r?glandium

Review commit: https://reviewboard.mozilla.org/r/34885/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34885/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8719093 [details]
MozReview Request: Bug 1248092 - Replace preprocessor -I with CONFIGURE_SUBST_FILES. r?glandium

https://reviewboard.mozilla.org/r/34885/#review31581

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05f8a1a4c09f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/05f8a1a4c09f

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8719093 [details]
MozReview Request: Bug 1248092 - Replace preprocessor -I with CONFIGURE_SUBST_FILES. r?glandium

Approval Request Comment
[Feature/regressing bug #]: bug 1235109
[User impact if declined]: 46.0 beta builds will fail to compile
[Describe test coverage new/current, TreeHerder]: Both present in nightly
[Risks and why]: None known, nalexander is the expert
[String/UUID change made/needed]: None

Bug 1235109 removes build system support for a type of preprocessing in 46, but the mobile change to stop using that is only in 47. We need to uplift this patch to avoid compile failures.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8719093 [details]
MozReview Request: Bug 1248092 - Replace preprocessor -I with CONFIGURE_SUBST_FILES. r?glandium

Taking it to make sure that 46 is fixed.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b7770ba5c620