1248097 - Add some more features to SpecialPowers.createFiles()

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Andrew McCreight [:mccr8]]

For bug 1243577 I need a couple of additional abilities for SpecialPowers.createFiles(). First, if a name is omitted, use createUnique to come up with one. Most (or maybe all) of the tests don't really care what the file name is. Second, the child should be able to pass in an "options" argument to be used as the second argument to the File constructor.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Fix indentation in SpecialPowersObserver.jsm.

I'm not sure what happened here.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2aa2a7e25c6a

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - If no name is specified for createFiles, use createUnique to create one.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Add file creation support for options.

This is pretty trivial. It just passes through an additional argument to the WebIDL File constructor.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Don't throw away the _createdFiles array every time.

This would cause us to not delete some created files if SpecialPowers.createFiles() is called multiple times in a single test.

I noticed this while I was looking at the code. There's no test because I'd have to change the removeFiles API (which is currently called automatically from finishTest() to do a callback when it finishes which seems like a bit of a pain. Leaving around a few files doesn't seem like a huge deal.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8720575 [details] [diff] [review]
part 1 - Fix indentation in SpecialPowersObserver.jsm.

Review of attachment 8720575 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/specialpowers/content/SpecialPowersObserver.jsm
@@ +266,5 @@
>              outStream.write(request.data, request.data.length);
>              outStream.close();
>            }
>            filePaths.push(new File(testFile.path));
>            createdFiles.push(testFile);

I am not sure why we went from 2 space indentation to 6 space.  Either way, these indentations are only half of the code inside the forEach.

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Joel Maher (:jmaher) from comment #5)
> I am not sure why we went from 2 space indentation to 6 space.  Either way,
> these indentations are only half of the code inside the forEach.

Sorry, I'm not sure what you mean here. All of the code inside the forEach is correctly indented now. Did you mean to r- my patch? If so, what do I need to fix? Thanks.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8720575 [details] [diff] [review]
part 1 - Fix indentation in SpecialPowersObserver.jsm.

Review of attachment 8720575 [details] [diff] [review]:
-----------------------------------------------------------------

oh silly me, I read the patch backwards.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/170e7f4744fe
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cf13bbd3e20
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d422cabebc4
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e5ea6598f40

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/170e7f4744fe
https://hg.mozilla.org/mozilla-central/rev/1cf13bbd3e20
https://hg.mozilla.org/mozilla-central/rev/5d422cabebc4
https://hg.mozilla.org/mozilla-central/rev/6e5ea6598f40