Closed
Bug 1248161
Opened 10 years ago
Closed 10 years ago
Remove duplicated entry in devtools/.eslintrc
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Honza, Assigned: Honza)
Details
Attachments
(1 file)
|
1.29 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
devtools/.eslintrc contians duplicated entry
"space-after-function-name": 0,
Honza
| Assignee | ||
Comment 1•10 years ago
|
||
Updated•10 years ago
|
Attachment #8719186 -
Flags: review?(pbrosset) → review+
Comment 3•10 years ago
|
||
I've pushed this to fx-team after realizing that moving to eslint 2.0 broke our eslint build ...
If you run mach eslint --setup today, this upgrades eslint to 2.0.0 (which must have been released on npm last week), and because it comes with a number of non-backward compatible changes, that ends up breaking some things.
It also emits 2 warnings for other rules. I'll file another bug.
warning Rule 'space-after-keywords' was removed and replaced by: keyword-spacing space-after-keywords
warning Rule 'space-return-throw-case' was removed and replaced by: keyword-spacing space-return-throw-case
| Assignee | ||
Comment 4•10 years ago
|
||
Great, thanks!
Honza
| Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 5•10 years ago
|
||
| bugherder | ||
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•