Closed
Bug 1248196
Opened 8 years ago
Closed 8 years ago
|git mozreview push| did not recognize updated reviewers in commit messages
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1238353
People
(Reporter: nalexander, Unassigned)
References
Details
I can think of two things that might cause the log below. The first is that the changed commits are really not recognized. (The line saying "remote: added 3 changesets with 0 changes to 15 files (+1 heads)" is pretty suspicious.) The seconds is that "ted.mielczarek" parses as "ted". nalexander@chocho ~/M/gecko.git> git mozreview push remote: adding changesets remote: adding manifests remote: adding file changes remote: added 3 changesets with 21 changes to 15 files (+1 heads) remote: recorded push in pushlog submitting 3 commits for review unrecognized reviewer: ted unrecognized reviewer: ted unrecognized reviewer: ted commit: de9f905 Bug 1248160 - Part 1: Remove MOZ_ANDROID_SHARED_ACCOUNT_TYPE. r?ted review: https://reviewboard.mozilla.org/r/34907 (draft) commit: 0715994 Bug 1248160 - Part 2: Inline MOZ_ANDROID_SHARED_FXACCOUNT_TYPE. r?ted review: https://reviewboard.mozilla.org/r/34909 (draft) commit: 9ef38bf Bug 1248160 - Part 3: Move MOZ_ANDROID_SHARED_ID to branding; remove mobile/android/defs.mk. r?ted review: https://reviewboard.mozilla.org/r/34911 (draft) (review requests lack reviewers; visit review url to assign reviewers) publish these review requests now (Yn)? n (visit review url to publish these review requests so others can see them) nalexander@chocho ~/M/gecko.git> git mozreview push remote: adding changesets remote: adding manifests remote: adding file changes remote: added 3 changesets with 0 changes to 15 files (+1 heads) remote: recorded push in pushlog submitting 3 commits for review unrecognized reviewer: ted unrecognized reviewer: ted unrecognized reviewer: ted commit: 3268478 Bug 1248160 - Part 1: Remove MOZ_ANDROID_SHARED_ACCOUNT_TYPE. r?ted.mielczarek review: https://reviewboard.mozilla.org/r/34907 (draft) commit: e77988e Bug 1248160 - Part 2: Inline MOZ_ANDROID_SHARED_FXACCOUNT_TYPE. r?ted.mielczarek review: https://reviewboard.mozilla.org/r/34909 (draft) commit: eb1a953 Bug 1248160 - Part 3: Move MOZ_ANDROID_SHARED_ID to branding; remove mobile/android/defs.mk. r?ted.mielczarek review: https://reviewboard.mozilla.org/r/34911 (draft) (review requests lack reviewers; visit review url to assign reviewers) publish these review requests now (Yn)?
Reporter | ||
Comment 1•8 years ago
|
||
To be clear: I've s/ted/ted.mielczarek/ in the commit messages between the two |git mozreview push| invocations.
this is happening because a period isn't valid in an irc nick.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•8 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•