[gui] AssertionError when double click the first/last on Build skipped dialog

NEW
Unassigned

Status

defect
4 years ago
4 years ago

People

(Reporter: yfdyh000, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

STR:
Run a new bisection, any range.
Use the 'Skip' action.
Double click the first/last build box.


Actual results:
platform: Windows-10-10.0.10586
python: 2.7.11 FROZEN (32bit)
mozregui: 0.9.0
mozregression: 2.3.0
message: AssertionError: 
traceback:   File ".\mozregui\bisection.py", line 254, in choose_next_build
  File ".\mozregui\skip_chooser.py", line 111, in choose_next_build


Expected Results:
No error, and the first/last builds should be available (not gray), I want to test them to verify my range. And if can easily correct the range, it would be better (bug 1239150).
(In reply to YF (Yang) from comment #0)
> STR:
> Run a new bisection, any range.
> Use the 'Skip' action.
> Double click the first/last build box.
> 
> 
> Actual results:
> platform: Windows-10-10.0.10586
> python: 2.7.11 FROZEN (32bit)
> mozregui: 0.9.0
> mozregression: 2.3.0
> message: AssertionError: 
> traceback:   File ".\mozregui\bisection.py", line 254, in choose_next_build
>   File ".\mozregui\skip_chooser.py", line 111, in choose_next_build
> 
> 
> Expected Results:
> No error, and the first/last builds should be available (not gray), I want
> to test them to verify my range. And if can easily correct the range, it
> would be better (bug 1239150).

Well we should not allow to select those builds. The way mozregression range works is that it knows that first is good, and last is bad.

Testing the initial range though is something needed, I filed bug 1248239 for that.

So I propose that here we just fix the error when selecting the gray builds in this bug - disallow their selection. Do you agree ?
See Also: → 1248239
I have no objection. I hope the ui improvement suggestions to implemented in the future versions, but whether here or not in this bug.
You need to log in before you can comment on or make changes to this bug.