1248252 - Improper outdated octal constant syntax in M-C tree.

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[ISHIKAWA, Chiaki]

It has been suggested that the original patch for m-c tree is filed in a separate bugzilla and I am doing this now.

+++ This bug was initially created as a clone of Bug #1247368 +++

(Sorry I put this into Untriaged component. That there is no clearly marked "Testing" entry speaks of some issues with the current framework.)

In continuation of the following bug, I will be posting oudated octal literal syntax usage in C-C tree and M-C tree.

+++ This bug was initially created as a clone of Bug #1247052 +++

File mailnews/compose/test/unit/test_bug235432.js
has an outdated octal constant format on line 80 0600 as opposed to proper 0o600 

This results in warning/syntax error during C-C TB's xpcshell-tests run.

This should be fixed to remove any clutter from the log.

Comment 1

[ISHIKAWA, Chiaki]

Attachment: Use '0o' prefix for octal literal constant in m-c tree.

Here is the patch. Can anyone suggest a proper reviewer?

TIA

Comment 2

[ISHIKAWA, Chiaki]

Oops, sorry I didn't realize that the CC-list is also copied from the original bug.

Comment 3

[ISHIKAWA, Chiaki]

Attachment: Use '0o' prefix for octal literal constant in m-c tree. Carrying over r=[e-mail]

Thank you for the quick review.

Here is the patch with somewhat updated description line that added r=[e-mail] at the end.

I am going to put checkin-needed keyword.

Thank you again.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9eeb24ae183d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9eeb24ae183d