Closed Bug 1248252 Opened 5 years ago Closed 5 years ago

Improper outdated octal constant syntax in M-C tree.

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: ishikawa, Assigned: ishikawa)

References

Details

Attachments

(1 file, 1 obsolete file)

It has been suggested that the original patch for m-c tree is filed in a separate bugzilla and I am doing this now.

+++ This bug was initially created as a clone of Bug #1247368 +++

(Sorry I put this into Untriaged component. That there is no clearly marked "Testing" entry speaks of some issues with the current framework.)

In continuation of the following bug, I will be posting oudated octal literal syntax usage in C-C tree and M-C tree.

+++ This bug was initially created as a clone of Bug #1247052 +++

File mailnews/compose/test/unit/test_bug235432.js
has an outdated octal constant format on line 80 0600 as opposed to proper 0o600 

This results in warning/syntax error during C-C TB's xpcshell-tests run.

This should be fixed to remove any clutter from the log.
Assignee: nobody → ishikawa
Here is the patch. Can anyone suggest a proper reviewer?

TIA
No longer depends on: 1247368, 1247052
See Also: → 1247368
Oops, sorry I didn't realize that the CC-list is also copied from the original bug.
Component: Untriaged → General
Attachment #8719283 - Flags: review?(dao)
Attachment #8719283 - Flags: review?(dao) → review+
Thank you for the quick review.

Here is the patch with somewhat updated description line that added r=dao@mozilla.com at the end.

I am going to put checkin-needed keyword.

Thank you again.
Attachment #8719283 - Attachment is obsolete: true
Attachment #8719525 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9eeb24ae183d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.