Closed Bug 1248301 Opened 4 years ago Closed 4 years ago

Horizontal scrollbar appears in console

Categories

(DevTools :: Console, defect, P1)

46 Branch
defect

Tracking

(firefox45 unaffected, firefox46+ fixed, firefox47+ fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox45 --- unaffected
firefox46 + fixed
firefox47 + fixed

People

(Reporter: Oriol, Assigned: bgrins)

References

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160214030236

Steps to reproduce:

Open console and keep entering some text (e.g spaces).



Actual results:

When the content is too tall, a vertical scrollbar appears as expected.

Since this scrollbar occupies some width, a horizontal scrollbar appears too.


Expected results:

There shouldn't be any horizontal scrollbar.

Just resizing the browser removes the scrollbar.

Culprit: https://hg.mozilla.org/integration/fx-team/rev/1aed451f1502
Blocks: 1237368
Component: Untriaged → Developer Tools: Console
Keywords: regression
ni? :bgrins since he worked on bug 1237368.
Flags: needinfo?(bgrinstead)
Alternative steps:

1. Open the console
2. Enter an object, e.g. []
3. Click it to open the object inspector
4. Resize the object inspector towards the left

The horizontal scrollbar blinks.
Can confirm, thanks for the report
Assignee: nobody → bgrinstead
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(bgrinstead)
Priority: -- → P1
[Tracking Requested - why for this release]: Visual regression causing extra scrollbar in web console output since Bug 1237368
Comment on attachment 8720412 [details]
MozReview Request: 1248301- Do not cause a horizontal scrollbar to appear in the console when it overflows vertically;r=vporof

https://reviewboard.mozilla.org/r/35299/#review32409

::: devtools/client/webconsole/webconsole.js:2094
(Diff revision 1)
> +    this.resize();

Does this have any impact on performance?
Attachment #8720412 - Flags: review?(vporof) → review+
(In reply to Victor Porof [:vporof][:vp] from comment #6)
> Comment on attachment 8720412 [details]
> MozReview Request: 1248301- Do not cause a horizontal scrollbar to appear in
> the console when it overflows vertically;r=vporof
> 
> https://reviewboard.mozilla.org/r/35299/#review32409
> 
> ::: devtools/client/webconsole/webconsole.js:2094
> (Diff revision 1)
> > +    this.resize();
> 
> Does this have any impact on performance?

If so, DAMP should catch it now after Bug 1239750
https://hg.mozilla.org/mozilla-central/rev/da87b650c2f6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Hi Oriol, can you please verify that this bug is now fixed on a Nightly build?
Flags: needinfo?(oriol-bugzilla)
Now it's much better, because the horizontal scrollbar doesn't appear when the content becomes too tall.

However, when I resize the object inspector to the left, the scrollbar still appears and disappears rapidly, it's a bit annoying. Should that be fixed in another bug?
Flags: needinfo?(oriol-bugzilla)
(In reply to Oriol from comment #12)
> Now it's much better, because the horizontal scrollbar doesn't appear when
> the content becomes too tall.

Thanks for the report and follow up!

> However, when I resize the object inspector to the left, the scrollbar still
> appears and disappears rapidly, it's a bit annoying. Should that be fixed in
> another bug?

Yes, can you please file another bug for this?
Comment on attachment 8720412 [details]
MozReview Request: 1248301- Do not cause a horizontal scrollbar to appear in the console when it overflows vertically;r=vporof

Approval Request Comment
[Feature/regressing bug #]: 1237368
[User impact if declined]: A horizontal scrollbar will be visible in the console once enough messages have shown up to cause vertical overflow
[Describe test coverage new/current, TreeHerder]: The console has lots of integration tests.  But no test for this change, it's reusing a function that sets the width of the console output area (same function that's called on a window resize, just now also calling it when messages are added)
[Risks and why]: Chance of a performance issue (we will be notified by Talos if this is the case).  The regressing bug made a massive improvement in the console output performance, so even if this caused a slowdown it would still be a net gain since before regressing bug
[String/UUID change made/needed]: None
Attachment #8720412 - Flags: approval-mozilla-aurora?
See Also: → 1250633
Comment on attachment 8720412 [details]
MozReview Request: 1248301- Do not cause a horizontal scrollbar to appear in the console when it overflows vertically;r=vporof

Fix for regression from 46. OK to uplift to aurora.
Attachment #8720412 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
See Also: → 1260071
See Also: → 1261533
bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test Successful

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Yes

Actual Results: 
As expected
Successfully reproduce this bug on Nightly 47.0a1 (2016-02-14) (Build ID: 20160214030236) on Linux, 64 Bit by following the comment 0' instruction !

This Bug is now verified as fixed on Latest Firefox Developer Edition 47.0a2 (2016-04-14) ;
(Build ID: 20160414004009)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0 and

Latest Firefox Beta 46.0b9 (Build ID: 20160411042519)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
OS: Linux 3.19.0-58-generic x86-64
QA Whiteboard: [bugday-20160413]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.