1248314 - Remove DecodedStreamData::mStreamInitialized

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

We can remove DecodedStreamData::mStreamInitialized by moving track initialization code from DecodedStream::InitTracks() into the constructor of DecodedStreamData which will run once only.

This small refactoring is a step forward to bug 1248312.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f904fe233ab

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1248314. Part 1 - Since OutputStreamManager::Connect/Disconnect is tightly coupled with the constructor/destructor of DecodedStreamData, it would improve cohesion to let DecodedStreamData manage an OutputStreamManager and know when

Review commit: https://reviewboard.mozilla.org/r/34949/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34949/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1248314. part 2 - move track initialization code into the constructor of DecodedStreamData. r=roc.

Review commit: https://reviewboard.mozilla.org/r/34951/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34951/

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8719365 [details]
MozReview Request: Bug 1248314. Part 1 - Since OutputStreamManager::Connect/Disconnect is tightly coupled with the constructor/destructor of DecodedStreamData, it would improve cohesion to let DecodedStreamData manage an OutputStreamManager and know when 

https://reviewboard.mozilla.org/r/34949/#review31527

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8719366 [details]
MozReview Request: Bug 1248314. part 2 - move track initialization code into the constructor of DecodedStreamData. r=roc.

https://reviewboard.mozilla.org/r/34951/#review31529

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2392845b26e4
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fa44352d55c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2392845b26e4
https://hg.mozilla.org/mozilla-central/rev/2fa44352d55c